Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: views/controls/textfield/native_textfield_views_unittest.cc

Issue 8524008: Fix the double/tripple click behavior of NataiveTextfieldViews objects. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the RTL unit test failure. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | views/metrics_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/textfield/native_textfield_views_unittest.cc
diff --git a/views/controls/textfield/native_textfield_views_unittest.cc b/views/controls/textfield/native_textfield_views_unittest.cc
index f0c24b78d6ddd5bb8f20d62c8d51b2eabc000433..ebc14cb15d722515b96097e304ca015f0d325928 100644
--- a/views/controls/textfield/native_textfield_views_unittest.cc
+++ b/views/controls/textfield/native_textfield_views_unittest.cc
@@ -1537,6 +1537,8 @@ TEST_F(NativeTextfieldViewsTest, OverflowInRTLTest) {
display = GetDisplayRect();
OverflowCursorBoundTestVerifier(display, bound);
+ // Sleep 1 second to simulate another single click.
+ base::PlatformThread::Sleep(1000);
msw 2011/11/12 00:09:08 See the code around line 1377 in NativeTextfieldVi
jennyz 2011/11/12 00:13:35 I tried NonClientMouseClick() first, but it does n
xji 2011/11/12 01:26:32 I tried sleep() before but that makes a test (with
msw 2011/11/12 02:02:45 I'd prefer that we fix NonClientClick first; but i
jennyz 2011/11/14 17:26:42 Done. Filed a bug for NonClientMouseClick. http://
msw 2011/11/14 18:21:25 Please add a comment here with that bug number.
MouseClick(bound, 1);
#if defined(OS_WIN)
// In Windows, the text is always in LTR directionality even in RTL UI.
« no previous file with comments | « no previous file | views/metrics_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698