Change the native_client chromium build to use the third_party/jsoncpp.

Change the native_client to use the third_party/jsoncpp.

BUG=102448
TEST=Compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109737

[Ronghua Wu (Left Chromium), 2011-11-10 18:53:56]

Hi David,

These changes are probably not enough. But I think I should get you involved
earlier before I dig into it.

Nico suggested to change third_party jsoncpp.gyp to the nativecl version of
jsoncpp.gyp. But I think if those " turn warnings off" is only for the
standalone build, we should not have it for chromium. Correct?

I'm not very clear about the structure/dependency here. There're native_client
and ppapi folders, and it seems the
ppapi/native_client/src/trusted/plugin/plugin.gyp
 only refers to the native_client. So I'm not even sure if plugin.gyp has access
to chromium third_party, although I did that in the cl. Please advice.

Nico also suggested to copy the third_party/jsoncpp folder to
native_client/src/third_party/. After a further thought, if all the parts of the
native_client that depends on jsoncpp is now in chromium, do we still need to
keep a copy of the jsoncpp inside native_client?

[sehr (please use chromium), 2011-11-11 00:52:55]

On 2011/11/10 18:53:56, Ronghua Wu wrote:
> Hi David,
> 
> These changes are probably not enough. But I think I should get you involved
> earlier before I dig into it.
> 
> Nico suggested to change third_party jsoncpp.gyp to the nativecl version of
> jsoncpp.gyp. But I think if those " turn warnings off" is only for the
> standalone build, we should not have it for chromium. Correct?
> 
> I'm not very clear about the structure/dependency here. There're native_client
> and ppapi folders, and it seems the
> ppapi/native_client/src/trusted/plugin/plugin.gyp
>  only refers to the native_client. So I'm not even sure if plugin.gyp has
access
> to chromium third_party, although I did that in the cl. Please advice.
> 
> Nico also suggested to copy the third_party/jsoncpp folder to
> native_client/src/third_party/. After a further thought, if all the parts of
the
> native_client that depends on jsoncpp is now in chromium, do we still need to
> keep a copy of the jsoncpp inside native_client?

It looks great so far.  If chrome builds, go ahead.  We'll take over then and
remove the jsoncpp directory from native_client.

[Ronghua Wu (Left Chromium), 2011-11-11 17:50:12]

On 2011/11/11 00:52:55, sehr wrote:
> On 2011/11/10 18:53:56, Ronghua Wu wrote:
> > Hi David,
> > 
> > These changes are probably not enough. But I think I should get you involved
> > earlier before I dig into it.
> > 
> > Nico suggested to change third_party jsoncpp.gyp to the nativecl version of
> > jsoncpp.gyp. But I think if those " turn warnings off" is only for the
> > standalone build, we should not have it for chromium. Correct?
> > 
> > I'm not very clear about the structure/dependency here. There're
native_client
> > and ppapi folders, and it seems the
> > ppapi/native_client/src/trusted/plugin/plugin.gyp
> >  only refers to the native_client. So I'm not even sure if plugin.gyp has
> access
> > to chromium third_party, although I did that in the cl. Please advice.
> > 
> > Nico also suggested to copy the third_party/jsoncpp folder to
> > native_client/src/third_party/. After a further thought, if all the parts of
> the
> > native_client that depends on jsoncpp is now in chromium, do we still need
to
> > keep a copy of the jsoncpp inside native_client?
> 
> It looks great so far.  If chrome builds, go ahead.  We'll take over then and
> remove the jsoncpp directory from native_client.

Do you want to approve this then? I will run some try jobs at the same time.

[Nico, 2011-11-11 19:02:03]

The tryjobs suggest this is all good.

Thanks for tackling this!

[Ronghua Wu (Left Chromium), 2011-11-11 19:23:57]

On 2011/11/11 19:02:03, Nico wrote:
> The tryjobs suggest this is all good.
> 
> Thanks for tackling this!

Great! Though I saw some errors in the cros build. Is that fine? I should have
picked a greener base to try on.

David, are you ok with the changes?

[sehr (please use chromium), 2011-11-11 23:03:17]

On 2011/11/11 19:23:57, Ronghua Wu wrote:
> On 2011/11/11 19:02:03, Nico wrote:
> > The tryjobs suggest this is all good.
> > 
> > Thanks for tackling this!
> 
> Great! Though I saw some errors in the cros build. Is that fine? I should have
> picked a greener base to try on.
> 
> David, are you ok with the changes?

Sorry.  I reviewed this but never hit send.  LGTM!  Thanks.

[commit-bot: I haz the power, 2011-11-11 23:06:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ronghuawu@chromium.org/8524002/2001

[commit-bot: I haz the power, 2011-11-12 00:22:03]

Change committed as 109737