Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/renderer/extensions/user_script_idle_scheduler.cc

Issue 8523037: base::Bind migrations in chrome/renderer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/user_script_idle_scheduler.cc
===================================================================
--- chrome/renderer/extensions/user_script_idle_scheduler.cc (revision 110185)
+++ chrome/renderer/extensions/user_script_idle_scheduler.cc (working copy)
@@ -4,6 +4,7 @@
#include "chrome/renderer/extensions/user_script_idle_scheduler.h"
+#include "base/bind.h"
#include "base/message_loop.h"
#include "chrome/common/extensions/extension_error_utils.h"
#include "chrome/common/extensions/extension_messages.h"
@@ -30,7 +31,7 @@
UserScriptIdleScheduler::UserScriptIdleScheduler(
WebFrame* frame, ExtensionDispatcher* extension_dispatcher)
- : ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
+ : ALLOW_THIS_IN_INITIALIZER_LIST(weak_factory_(this)),
frame_(frame),
has_run_(false),
extension_dispatcher_(extension_dispatcher) {
@@ -52,22 +53,24 @@
}
void UserScriptIdleScheduler::DidFinishDocumentLoad() {
- MessageLoop::current()->PostDelayedTask(FROM_HERE,
- method_factory_.NewRunnableMethod(&UserScriptIdleScheduler::MaybeRun),
+ MessageLoop::current()->PostDelayedTask(
+ FROM_HERE, base::Bind(&UserScriptIdleScheduler::MaybeRun,
+ weak_factory_.GetWeakPtr()),
kUserScriptIdleTimeoutMs);
}
void UserScriptIdleScheduler::DidFinishLoad() {
// Ensure that running scripts does not keep any progress UI running.
- MessageLoop::current()->PostTask(FROM_HERE,
- method_factory_.NewRunnableMethod(&UserScriptIdleScheduler::MaybeRun));
+ MessageLoop::current()->PostTask(
+ FROM_HERE, base::Bind(&UserScriptIdleScheduler::MaybeRun,
+ weak_factory_.GetWeakPtr()));
}
void UserScriptIdleScheduler::DidStartProvisionalLoad() {
// The frame is navigating, so reset the state since we'll want to inject
// scripts once the load finishes.
has_run_ = false;
- method_factory_.RevokeAll();
+ weak_factory_.InvalidateWeakPtrs();
while (!pending_code_execution_queue_.empty())
pending_code_execution_queue_.pop();
}
« no previous file with comments | « chrome/renderer/extensions/user_script_idle_scheduler.h ('k') | chrome/renderer/net/renderer_net_predictor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698