Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issue 8523029: Ensure that WebKit can use envsetup.sh (Closed)

Created:
9 years, 1 month ago by Peter Beverloo
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Ensure that WebKit can use envsetup.sh Right now Android's envsetup.sh requires the chdir to be in Chromium's src directory, whereas this will be different for WebKit. Furthermore, disabling build_ffmpegsumo will resolve a gyp error in ffmpeg.gyp. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110697

Patch Set 1 #

Patch Set 2 : Prefer -n over negated -z #

Total comments: 1

Patch Set 3 : Add an explanation #

Patch Set 4 : Remove the usage of "we" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/android/envsetup.sh View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Peter Beverloo
Hi guys, mind having a quick look before I send this to a build/ reviewer? ...
9 years, 1 month ago (2011-11-16 12:13:21 UTC) #1
michaelbai
lgtm
9 years, 1 month ago (2011-11-16 17:20:54 UTC) #2
John Grabowski
http://codereview.chromium.org/8523029/diff/2001/build/android/envsetup.sh File build/android/envsetup.sh (right): http://codereview.chromium.org/8523029/diff/2001/build/android/envsetup.sh#newcode79 build/android/envsetup.sh:79: [ -n "${WEBKIT_ANDROID_BUILD}" ]; then This needs doc or ...
9 years, 1 month ago (2011-11-16 19:40:21 UTC) #3
Peter Beverloo
On 2011/11/16 19:40:21, John Grabowski wrote: > http://codereview.chromium.org/8523029/diff/2001/build/android/envsetup.sh > File build/android/envsetup.sh (right): > > http://codereview.chromium.org/8523029/diff/2001/build/android/envsetup.sh#newcode79 ...
9 years, 1 month ago (2011-11-17 17:10:12 UTC) #4
Mark Mentovai
LGTM, although I find comments are clearer when you don’t write “we” or “our” in ...
9 years, 1 month ago (2011-11-17 18:04:51 UTC) #5
John Grabowski
On 2011/11/17 18:04:51, Mark Mentovai wrote: > LGTM, although I find comments are clearer when ...
9 years, 1 month ago (2011-11-17 18:18:40 UTC) #6
Mark Mentovai
jrg@chromium.org wrote: > He's Dutch; that's how verbs translate. That made my day!
9 years, 1 month ago (2011-11-17 18:21:53 UTC) #7
Peter Beverloo
9 years, 1 month ago (2011-11-17 18:37:11 UTC) #8
Patch for landing.

Thanks Mark, I've updated the comment. I'll keep it in mind.
Yeah. Thank you too, John :-).

Powered by Google App Engine
This is Rietveld 408576698