Change snasphotting API to take in a bounds Rect

chrome/browser/ui/webui/bug_report_ui.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/bug_report_ui.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 121 matching lines @@
     // Do not refresh screenshot, do not create a new tab
     browser->ActivateTabAt(feedback_tab_index, true);
     return;
   }
 
   std::vector<unsigned char>* last_screenshot_png =
       BugReportUtil::GetScreenshotPng();
   last_screenshot_png->clear();
 
   gfx::NativeWindow native_window = browser->window()->GetNativeHandle();
-  BugReportUtil::SetScreenshotSize(
-      browser::GrabWindowSnapshot(native_window, last_screenshot_png));

[Nico, 2011/11/15 17:10:09]

nit: I liked the old interface better for the use case in this file. I would've
left the old interface intact, added a new function for your use case, and then
implemented the old one in terms of the new one. That's just me, though :-)

+  gfx::Rect window_bounds = browser->window()->GetBounds();
+  bool success = browser::GrabWindowSnapshot(native_window,
+                                             last_screenshot_png,
+                                             window_bounds);

[sky, 2011/11/15 16:58:08]

Don't you need to convert window_bounds to have an origin of 0x0?

+  BugReportUtil::SetScreenshotSize(success ? window_bounds : gfx::Rect());
 
   std::string bug_report_url = std::string(chrome::kChromeUIBugReportURL) +
       "#" + base::IntToString(browser->active_index()) +
       "?description=" + net::EscapeUrlEncodedData(description_template, false) +
       "&issueType=" + base::IntToString(issue_type);
   browser->ShowSingletonTab(GURL(bug_report_url));
 }
 
 }  // namespace browser
 
@@ skipping 463 matching lines @@
   AddMessageHandler((handler)->Attach(this));
 
   // The handler's init will determine whether we show the error html page.
   ChromeWebUIDataSource* html_source =
       CreateBugReportUIHTMLSource(handler->Init());
 
   // Set up the chrome://bugreport/ source.
   Profile* profile = Profile::FromBrowserContext(tab->browser_context());
   profile->GetChromeURLDataManager()->AddDataSource(html_source);
 }