Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 8523020: Fix menu crash (Closed)

Created:
9 years, 1 month ago by oshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Emmanuel Saint-loubert-BiƩ
Visibility:
Public.

Description

Fix menu crash Made GetActivatableWindow to follow transient_parent if exists. BUG=103820 TEST=tbd Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109660

Patch Set 1 #

Patch Set 2 : check transient path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/aura_shell/stacking_controller.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
oshima
I'm not 100% certain if this is the right fix, but does fix the crash. ...
9 years, 1 month ago (2011-11-10 23:47:44 UTC) #1
oshima
On 2011/11/10 23:47:44, oshima wrote: > I'm not 100% certain if this is the right ...
9 years, 1 month ago (2011-11-11 00:32:06 UTC) #2
oshima
Uploaded new patch. PTAL. I updated GetActivatableWindow to follow transient_paernt because if the window is ...
9 years, 1 month ago (2011-11-11 01:35:51 UTC) #3
Ben Goodger (Google)
lgtm
9 years, 1 month ago (2011-11-11 17:14:25 UTC) #4
oshima
9 years, 1 month ago (2011-11-11 17:26:16 UTC) #5
since this is crasher, I'll check this in first and add test in follow up
cl.

On Fri, Nov 11, 2011 at 9:14 AM, <ben@chromium.org> wrote:

> lgtm
>
>
>
>
http://codereview.chromium.**org/8523020/<http://codereview.chromium.org/8523...
>

Powered by Google App Engine
This is Rietveld 408576698