Devirtualize CHROMEG_CALLBACK

Devirtualize CHROMEG_CALLBACK

This allows 4 classes to be completely devirtualized. For the moment, CHROMEGTK_CALLBACK is left as default virtual, since it's used throughout a lot of Widget code.

BUG=103827
TEST=passes all tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109709

[dcheng, 2011-11-11 08:09:14]

First part of cleaning this up a bit. If I'm feeling particularly ambitious,
I'll do the same thing with CHROMEGTK_CALLBACK.

[Elliot Glaysher, 2011-11-11 18:19:10]

lgtm

On 2011/11/11 08:09:14, dcheng wrote:
> First part of cleaning this up a bit. If I'm feeling particularly ambitious,
> I'll do the same thing with CHROMEGTK_CALLBACK.

Idea: Just turn everything in views/ and chrome/browser/chromeos/ into
CHROMEGTK_VIRTUAL callbacks to simplify your life. The ViewsGtk code is going
away soon.

[dcheng, 2011-11-11 18:39:08]

On 2011/11/11 18:19:10, Elliot Glaysher wrote:
> lgtm
> 
> On 2011/11/11 08:09:14, dcheng wrote:
> > First part of cleaning this up a bit. If I'm feeling particularly ambitious,
> > I'll do the same thing with CHROMEGTK_CALLBACK.
> 
> Idea: Just turn everything in views/ and chrome/browser/chromeos/ into
> CHROMEGTK_VIRTUAL callbacks to simplify your life. The ViewsGtk code is going
> away soon.

Adding OWNERS for approvals for content/* and ui/base/*.

[sky, 2011-11-11 18:48:42]

LGTM

[tfarina, 2011-11-11 19:28:16]

http://codereview.chromium.org/8523019/diff/4001/ui/base/glib/glib_signal.h
File ui/base/glib/glib_signal.h (right):

http://codereview.chromium.org/8523019/diff/4001/ui/base/glib/glib_signal.h#n...
ui/base/glib/glib_signal.h:24: #define CHROMEG_CALLBACK_0(CLASS, RETURN, METHOD,
SENDER)           \
since this in ui/base/ directory, would we rename it from CHROMEG_CALLBACK_0 to
UI_CALLBACK_0 or something else that doesn't have CHROME? In a another CL, of
course. I assume G stands for GLIB here.

[Evan Stade, 2011-11-11 22:27:36]

lgtm