chrome/browser/ui/views/file_manager_dialog_unittest.cc - Issue 8523006: Don't show FileManagerDialog if another FileManagerDialog is shown in the same tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/file_manager_dialog_unittest.cc

Issue 8523006: Don't show FileManagerDialog if another FileManagerDialog is shown in the same tab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: space Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/file_manager_dialog_unittest.cc

diff --git a/chrome/browser/ui/views/file_manager_dialog_unittest.cc b/chrome/browser/ui/views/file_manager_dialog_unittest.cc

index 33ad4f0aed2bfebbf88fcdfd93fbf3e3dd1cd9e2..122be1f5c97edb185fde5be4e6ae22c86dd375cd 100644

--- a/chrome/browser/ui/views/file_manager_dialog_unittest.cc

+++ b/chrome/browser/ui/views/file_manager_dialog_unittest.cc

@@ -13,7 +13,9 @@ class FileManagerDialogTest : public testing::Test {

int32 tab_id) {

FileManagerDialog* dialog = new FileManagerDialog(listener);

// Simulate the dialog opening.

+ EXPECT_FALSE(FileManagerDialog::PendingExists(tab_id));

dialog->AddPending(tab_id);

+ EXPECT_TRUE(FileManagerDialog::PendingExists(tab_id));

return dialog;

}

};

« no previous file with comments | « chrome/browser/ui/views/file_manager_dialog_browsertest.cc ('k') | no next file » | no next file with comments »