Issue 8520035: Revert 110264 - Fix for management API related to escalated permissions disabled extensions

Issue 8520035: Revert 110264 - Fix for management API related to escalated permissions disabled extensions (Closed)

Created:
9 years, 1 month ago by dpolukhin

Modified:
9 years, 1 month ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 110264 - Fix for management API related to escalated permissions disabled extensions The general approach is to require user gesture and put up the confirmation UI if an extension wants to re-enable a disabled-due-to-permissions-escalation extension. Also added some new infrastructure for making this easier to test. BUG=102579 TEST=See bug Review URL: http://codereview.chromium.org/8423069 TBR=asargent@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110268

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -514 lines)			Patch
M	chrome/browser/extensions/extension_function.h	View	2 chunks	+1 line, -15 lines	0 comments	Download
M	chrome/browser/extensions/extension_function.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_test_utils.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_test_utils.cc	View	2 chunks	+0 lines, -55 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.h	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_dialog.cc	View	4 chunks	+6 lines, -38 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.h	View	3 chunks	+2 lines, -23 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api.cc	View	14 chunks	+67 lines, -95 lines	0 comments	Download
M	chrome/browser/extensions/extension_management_api_browsertest.cc	View	2 chunks	+1 line, -86 lines	0 comments	Download
D	chrome/browser/extensions/extension_management_api_constants.h	View	1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/browser/extensions/extension_management_api_constants.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	chrome/browser/extensions/extension_webstore_private_apitest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/webstore_inline_install_browsertest.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_install_dialog_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.json	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/common/extensions/docs/management.html	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/management/test/basics.js	View	1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages