Issue 8520034: Add missing ConstrainedDialog code and re-enable disabled PrintPreviewHandlerTest tests on CrOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8520034: Add missing ConstrainedDialog code and re-enable disabled PrintPreviewHandlerTest tests on CrOS. (Closed)

Created:
9 years, 1 month ago by Lei Zhang

Modified:
9 years, 1 month ago

Reviewers:
dpapad

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add missing ConstrainedDialog code and re-enable disabled PrintPreviewHandlerTest tests on CrOS. BUG=104403 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110372

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
	M	chrome/browser/ui/views/constrained_html_delegate_gtk.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/webui/print_preview_handler_unittest.cc	View		5 chunks	+9 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

See dtor in the other ConstrainedHtmlDelegateGtk implementation.

9 years, 1 month ago (2011-11-16 08:36:07 UTC) #1

LGTM.