Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8520033: Add OVERRIDE to media/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, sadrul, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to media/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -138 lines) Patch
M media/audio/audio_input_controller.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_proxy.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/audio/fake_audio_input_stream.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/audio/fake_audio_output_stream.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/audio/mac/audio_low_latency_output_mac.h View 1 chunk +6 lines, -6 lines 0 comments Download
M media/audio/mac/audio_output_mac.h View 2 chunks +7 lines, -6 lines 0 comments Download
M media/audio/simple_sources.h View 2 chunks +9 lines, -7 lines 0 comments Download
M media/audio/test_audio_input_controller_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M media/base/async_filter_factory_base.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/buffers.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/composite_data_source_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/data_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/message_loop_factory_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm_default.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/audio_renderer_algorithm_ola.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/audio_renderer_base.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/bitstream_converter.h View 3 chunks +5 lines, -4 lines 0 comments Download
M media/filters/chunk_demuxer.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/chunk_demuxer_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_h264_bitstream_converter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/file_data_source.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/filters/file_data_source_factory.h View 1 chunk +3 lines, -2 lines 0 comments Download
M media/filters/in_memory_url_protocol.h View 1 chunk +5 lines, -5 lines 0 comments Download
media/filters/null_audio_renderer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M media/filters/null_video_renderer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/filters/reference_audio_renderer.h View 1 chunk +7 lines, -6 lines 0 comments Download
M media/filters/video_renderer_base.h View 1 chunk +9 lines, -9 lines 0 comments Download
M media/video/capture/fake_video_capture_device.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/video/capture/linux/video_capture_device_linux.h View 1 chunk +5 lines, -5 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.h View 1 chunk +5 lines, -5 lines 0 comments Download
media/webm/webm_cluster_parser.h View 1 chunk +7 lines, -7 lines 0 comments Download
M media/webm/webm_info_parser.h View 2 chunks +8 lines, -7 lines 0 comments Download
M media/webm/webm_tracks_parser.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
Just adding OVERRIDE annotations.
9 years, 1 month ago (2011-11-16 01:56:14 UTC) #1
scherkus (not reviewing)
9 years, 1 month ago (2011-11-16 02:06:53 UTC) #2 
LGTM

thanks!

as a side (and perhaps for chromium-dev), but does following IWYU imply that all
headers that use OVERRIDE have to include base/compiler_specific.h?  seems silly
:|

Powered by Google App Engine
This is Rietveld 408576698