Fix statics in NativeTheme*::instance() to avoid destruction post main

Fix statics in NativeTheme*::instance() to avoid destruction post main

Intentionally leaks NativeTheme* singletons to avoid destructor firing after main.  Memory bots will need suppressions for this.

Avoids clang error:

  time make -k -j16 compositor_unittests
    CXX(target) out/Debug/obj.target/ui/ui/gfx/native_theme_aura.o
  ui/gfx/native_theme_aura.cc:27:32: error: declaration requires an exit-time destructor [-Werror,-Wexit-time-destructors]
    static const NativeThemeAura s_native_theme;

BUG=none
TEST=compiles under clang -Wexit-time-destructors
R=jamescook@chromium.org, ben@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110334

[James Cook, 2011-11-16 00:28:46]

LGTM, but please let Ben comment too.

Thanks for fixing the include-what-you-use of basictypes.h.

[Ben Goodger (Google), 2011-11-16 16:36:38]

lgtm

[commit-bot: I haz the power, 2011-11-16 16:41:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/8520026/1

[commit-bot: I haz the power, 2011-11-16 18:06:48]

Try job failure for 8520026-1 (retry) on mac_rel for step "webkit_unit_tests".
It's a second try, previously, step "webkit_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Nico, 2011-11-16 19:27:20]

Thanks! The tracking bug for this is http://crbug.com/101600 .

basictypes.h is included transitively in almost every file already, so I usually
didn't bother listing it explicitly.