Updating the UMA metrics for profiles to make them more readable.

chrome/browser/profiles/profile_metrics.h

Index: chrome/browser/profiles/profile_metrics.h
===================================================================
--- chrome/browser/profiles/profile_metrics.h	(revision 110080)
+++ chrome/browser/profiles/profile_metrics.h	(working copy)
@@ -45,30 +45,43 @@
     NUM_PROFILE_AVATAR_METRICS
   };
 
+  // Enum for counting the ways users were added.
+  enum ProfileAdd {
+    ADD_NEW_USER_ICON = 0,    // User adds new user from icon menu
+    ADD_NEW_USER_MENU,        // User adds new user from menu bar
+    NUM_PROFILE_ADD_METRICS
+  };
+
+  // Enum for counting the ways user profiles were opened.
   enum ProfileOpen {
-    ADD_NEW_USER = 0,     // Total count of add new user
-    ADD_NEW_USER_ICON,    // User adds new user from icon menu
-    ADD_NEW_USER_MENU,    // User adds new user from menu bar
-    SWITCH_PROFILE_ICON,  // User switches profiles from icon menu
-    SWITCH_PROFILE_MENU,  // User switches profiles from menu bar
-    NTP_AVATAR_BUBBLE,    // User opens avatar icon menu from NTP
-    ICON_AVATAR_BUBBLE,   // User opens avatar icon menu from icon
-    PROFILE_DELETED,      // User deleted a profile
+    NTP_AVATAR_BUBBLE = 0,    // User opens avatar icon menu from NTP
+    ICON_AVATAR_BUBBLE,       // User opens avatar icon menu from icon
     NUM_PROFILE_OPEN_METRICS
   };
 
+  // Enum for counting the ways users switch between profiles.
+  enum ProfileSwitch {
+    SWITCH_PROFILE_ICON = 0,  // User switches profiles from icon menu
+    SWITCH_PROFILE_MENU,      // User switches profiles from menu bar
+    NUM_PROFILE_SWITCH_METRICS
+  };
+
+  // Enum for getting net counts for adding and deleting users.
+  enum ProfileNetUserCounts {
+    ADD_NEW_USER = 0,         // Total count of add new user
+    PROFILE_DELETED,          // User deleted a profile
+    NUM_PROFILE_NET_METRICS
+  };
+
   // Sign in is logged once the user has entered their GAIA information.
   // See sync_setup_flow.h.
   // The options for sync are logged after the user has submitted the options
   // form. See sync_setup_handler.h.
   enum ProfileSync {
-    SYNC_SIGN_IN = 0,        // User signed into sync
-    SYNC_SIGN_IN_ORIGINAL,   // User signed into sync in original profile
-    SYNC_SIGN_IN_SECONDARY,  // User signed into sync in secondary profile
-    SYNC_CUSTOMIZE,          // User decided to customize sync
-    SYNC_CHOOSE,             // User chose what to sync
-    SYNC_ENCRYPT,            // User has chosen to encrypt all data
-    SYNC_PASSPHRASE,         // User is using a passphrase
+    SYNC_CUSTOMIZE = 0,       // User decided to customize sync
+    SYNC_CHOOSE,              // User chose what to sync
+    SYNC_ENCRYPT,             // User has chosen to encrypt all data
+    SYNC_PASSPHRASE,          // User is using a passphrase

[Ilya Sherman, 2011/11/16 03:29:19]

Note that if you change the enum values, you should change the histogram name as
well.  Otherwise, you invalidate old data.  Another option in this case is to
declare """SYNC_CUSTOMIZE = 3""" with a comment explaining what happened to 0
through 2.

[rpetterson, 2011/11/16 22:46:25]

Fixed hte histogram name.

     NUM_PROFILE_SYNC_METRICS
   };
 
@@ -80,6 +93,9 @@
 
   static void LogProfileAvatarSelection(size_t icon_index);
   static void LogProfileOpenMethod(ProfileOpen metric);
+  static void LogProfileAddNewUser(ProfileAdd metric);
+  static void LogProfileSwitchUser(ProfileSwitch metric);
+  static void LogProfileDeleteUser(ProfileNetUserCounts metric);
   static void LogProfileSyncInfo(ProfileSync metric);
   static void LogProfileUpdate(FilePath& profile_path);
   static void LogProfileSyncSignIn(FilePath& profile_path);