Don't allow the task manager to share a process with anything else.

chrome/browser/chrome_content_browser_client.cc

Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 3853866cc2885f82e2853c3384b73dba49582390..04d0a03c4772a53e9af424097d6483a068ed7975 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -398,6 +398,14 @@ bool ChromeContentBrowserClient::IsSuitableHost(
   ExtensionService* service = profile->GetExtensionService();
   extensions::ProcessMap* process_map = service->process_map();
 
+  // Don't allow the Task Manager to share a process with anything else.

[awong, 2011/11/15 20:23:43]

Can we say "anything else, including other Task Managers"?

[Charlie Reis, 2011/11/15 20:28:38]

If we actually want to enforce that, we would also need to change how the
TaskManager's SiteInstance is obtained.  As it turns out, opening a second Task
Manager in a tab will sometimes share with the first one because they use the
same SiteInstance.  I don't think that's a big deal.

+  // Otherwise it can affect the renderers it is observing.
+  // Note: we could create another RenderProcessHostPrivilege bucket for
+  // this to allow multiple chrome://tasks instances to share, but that's
+  // a very unlikely case without serious consequences.
+  if (site_url == GURL(chrome::kChromeUITaskManagerURL))

[Aaron Boodman, 2011/11/15 21:08:37]

Nit: This kind of thing always makes me nervous. If anyone ever changes the task
manager to accept querystring arguments, or fragments, it will stop working.

Consider instead doing something like:

if (site_url.GetOrigin() == GURL(...).GetOrigin())

... but I would understand if you said that was overkill.

[Charlie Reis, 2011/11/15 21:29:48]

Yeah, I agree that would be more robust.  Fixed.

+    return false;
+
   // These may be NULL during tests. In that case, just assume any site can
   // share any host.
   if (!service || !process_map)