Issue 8520016: Complete the rename from about:tracking2 --> about:profiler by changing the implementation code t...

Issue 8520016: Complete the rename from about:tracking2 --> about:profiler by changing the implementation code t... (Closed)

Created:
9 years, 1 month ago by eroman

Modified:
8 years, 11 months ago

Reviewers:
jam, jar (doing other things)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Complete the rename from about:tracking2 --> about:profiler by changing the implementation code to always reference "profiler" rather than "tracking". BUG=100992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110207

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : moar #

Patch Set 4 : sync tracking.js #

Patch Set 5 : try synching again... #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -1753 lines)			Patch
M	chrome/browser/browser_resources.grd	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/metrics/tracking_synchronizer.h	View	1 2	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/metrics/tracking_synchronizer.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
A +	chrome/browser/resources/profiler.html	View	1 2 3 4	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/resources/profiler.js	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/resources/tracking.html	View	1 2 3 4	1 chunk	+0 lines, -112 lines	0 comments	Download
D	chrome/browser/resources/tracking.js	View	1 2 3	1 chunk	+0 lines, -1547 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_factory.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	chrome/browser/ui/webui/profiler_ui.h	View		3 chunks	+10 lines, -10 lines	0 comments	Download
A +	chrome/browser/ui/webui/profiler_ui.cc	View	1	6 chunks	+32 lines, -34 lines	0 comments	Download
D	chrome/browser/ui/webui/tracking_ui.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/url_constants.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/common/url_constants.cc	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/8520016/4004

9 years, 1 month ago (2011-11-15 20:03:19 UTC) #3

commit-bot: I haz the power

Can't apply patch for file chrome/browser/resources/profiler.html. While running patch -p0 --forward --force; patching file chrome/browser/resources/profiler.html ...

9 years, 1 month ago (2011-11-15 20:03:24 UTC) #4

jam

8 years, 11 months ago (2012-01-05 23:45:58 UTC) #7

cool, thanks :)

On Thu, Jan 5, 2012 at 3:39 PM, <eroman@chromium.org> wrote:

> Indeed I did! I will prepare a change right away.
>
>
http://codereview.chromium.**org/8520016/<http://codereview.chromium.org/8520...
>

Expand Messages | Collapse Messages