Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2295)

Unified Diff: chrome/browser/printing/print_preview_tab_controller.h

Issue 8520011: Print Preview: Make print preview tab modal. (try 2) (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: disable tests in touch_ui, fix failing test Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/print_preview_tab_controller.h
===================================================================
--- chrome/browser/printing/print_preview_tab_controller.h (revision 110066)
+++ chrome/browser/printing/print_preview_tab_controller.h (working copy)
@@ -72,6 +72,8 @@
// Erase the initiator tab info associated with |preview_tab|.
void EraseInitiatorTabInfo(TabContentsWrapper* preview_tab);
+ bool is_creating_print_preview_tab() const;
+
private:
friend class base::RefCounted<PrintPreviewTabController>;
@@ -104,6 +106,10 @@
void AddObservers(TabContentsWrapper* tab);
void RemoveObservers(TabContentsWrapper* tab);
+ // Removes tabs when they close/crash/navigate.
+ void RemoveInitiatorTab(TabContentsWrapper* initiator_tab);
+ void RemovePreviewTab(TabContentsWrapper* preview_tab);
+
// Mapping between print preview tab and the corresponding initiator tab.
PrintPreviewTabMap preview_tab_map_;
@@ -114,6 +120,10 @@
// content::NAVIGATION_TYPE_NEW_PAGE.
bool waiting_for_new_preview_page_;
+ // Whether the PrintPreviewTabController is in the middle of creating a
+ // print preview tab.
+ bool is_creating_print_preview_tab_;
+
DISALLOW_COPY_AND_ASSIGN(PrintPreviewTabController);
};

Powered by Google App Engine
This is Rietveld 408576698