Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issue 8520010: Fixing crash of StringHash test. (Closed)

Created:
9 years, 1 month ago by Yang
Modified:
9 years, 1 month ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Fixing crash of StringHash test. Committed: http://code.google.com/p/v8/source/detail?r=9962

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M test/cctest/test-hashing.cc View 3 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. Turned out I forgot to save and restore registers when I dived into generated ...
9 years, 1 month ago (2011-11-10 16:52:56 UTC) #1
rossberg
9 years, 1 month ago (2011-11-10 17:00:24 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698