Only show G+ promo for users logged into G+

chrome/browser/ui/webui/ntp/new_tab_page_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/new_tab_page_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
@@ skipping 48 matching lines @@
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("introMessageDismissed",
       base::Bind(&NewTabPageHandler::HandleIntroMessageDismissed,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("introMessageSeen",
       base::Bind(&NewTabPageHandler::HandleIntroMessageSeen,
                  base::Unretained(this)));
 }
 
 void NewTabPageHandler::HandleCloseNotificationPromo(const ListValue* args) {
-  NotificationPromo notification_promo(
-      Profile::FromWebUI(web_ui())->GetPrefs(), NULL);
-  notification_promo.HandleClosed();
+  NotificationPromo* notification_promo = NotificationPromo::Factory(

[achuithb, 2011/11/27 07:48:26]

This is a leak. Could you please use scoped_refptr<NotificationPromo> here?

[Cait (Slow), 2011/11/28 19:06:25]

Done.

+      Profile::FromWebUI(web_ui()), NULL);
+  notification_promo->HandleClosed();
   Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
 }
 
 void NewTabPageHandler::HandleNotificationPromoViewed(const ListValue* args) {
-  NotificationPromo notification_promo(
-      Profile::FromWebUI(web_ui_)->GetPrefs(), NULL);
-  if (notification_promo.HandleViewed())
+  NotificationPromo* notification_promo = NotificationPromo::Factory(

[achuithb, 2011/11/27 07:48:26]

scoped_refptr

[Cait (Slow), 2011/11/28 19:06:25]

Done.

+      Profile::FromWebUI(web_ui_), NULL);
+  if (notification_promo->HandleViewed())
     Notify(chrome::NOTIFICATION_PROMO_RESOURCE_STATE_CHANGED);
 }
 
 void NewTabPageHandler::HandlePageSelected(const ListValue* args) {
   double page_id_double;
   CHECK(args->GetDouble(0, &page_id_double));
   int page_id = static_cast<int>(page_id_double);
 
   double index_double;
   CHECK(args->GetDouble(1, &index_double));
@@ skipping 84 matching lines @@
   // is only called during startup before the ntp resource cache is constructed.
 }
 
 void NewTabPageHandler::Notify(chrome::NotificationType notification_type) {
   content::NotificationService* service =
       content::NotificationService::current();
   service->Notify(notification_type,
                   content::Source<NewTabPageHandler>(this),
                   content::NotificationService::NoDetails());
 }