Only show G+ promo for users logged into G+

chrome/browser/web_resource/promo_resource_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/web_resource/promo_resource_service.h"
 
 #include "base/command_line.h"
 #include "base/rand_util.h"
 #include "base/string_number_conversions.h"
+#include "base/string_split.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/apps_promo.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #include "chrome/common/chrome_notification_types.h"
@@ skipping 188 matching lines @@
   return local_state->GetInteger(prefs::kNTPPromoVersion);
 }
 
 std::string PromoResourceService::GetPromoLocale() {
   PrefService* local_state = g_browser_process->local_state();
   return local_state->GetString(prefs::kNTPPromoLocale);
 }
 
 void PromoResourceService::UnpackNotificationSignal(
     const DictionaryValue& parsed_json) {
-  NotificationPromo notification_promo(prefs_, this);
-  notification_promo.InitFromJson(parsed_json);
+  NotificationPromo* notification_promo =

[achuithb, 2011/11/16 20:33:11]

You are leaking NotificationPromo here. Please do:
scoped_refptr<NotificationPromo> notification_promo = 
NotificationPromo::Factory(profile_, this);

[Cait (Slow), 2011/11/16 23:05:24]

Done.

+      NotificationPromo::Factory(profile_, this);
+  notification_promo->InitFromJson(parsed_json);
 }
 
 bool PromoResourceService::CanShowNotificationPromo(Profile* profile) {
-  NotificationPromo notification_promo(profile->GetPrefs(), NULL);
-  notification_promo.InitFromPrefs();
-  return notification_promo.CanShow();
+  NotificationPromo* notification_promo =

[achuithb, 2011/11/16 20:33:11]

You are leaking NotificationPromo here. Please do:
scoped_refptr<NotificationPromo> notification_promo = 
NotificationPromo::Factory(profile_, this);

[Cait (Slow), 2011/11/16 23:05:24]

Done.

+      NotificationPromo::Factory(profile, NULL);
+  notification_promo->InitFromPrefs();
+  return notification_promo->CanShow();
 }
 
 void PromoResourceService::UnpackWebStoreSignal(
     const DictionaryValue& parsed_json) {
   DictionaryValue* topic_dict;
   ListValue* answer_list;
 
   bool is_webstore_active = false;
   bool signal_found = false;
   AppsPromo::PromoData promo_data;
@@ skipping 212 matching lines @@
   if (!prefs->HasPrefPath(prefs::kNTPSignInPromoGroup)) {
     prefs->SetInteger(prefs::kNTPSignInPromoGroup,
                       base::RandInt(1, kNTPSignInPromoNumberOfGroups));
   }
 
   // A response is not kept if the build wasn't targeted, so the only thing
   // required to check is the group this client has been tagged in.
   return prefs->GetInteger(prefs::kNTPSignInPromoGroupMax) >=
          prefs->GetInteger(prefs::kNTPSignInPromoGroup);
 }