Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 8519003: More unittests for webRequest API and better conflict resolution (Closed)

Created:
9 years, 1 month ago by battre
Modified:
9 years, 1 month ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

More unittests for webRequest API and better conflict resolution Added more unittests for the webRequest API and don't trigger conflicts anymore if two extensions try to modify requests in the same way. BUG=none TEST=no Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109609

Patch Set 1 #

Patch Set 2 : Cleanups #

Patch Set 3 : Uncommented block #

Patch Set 4 : Improve merging of header modifications in webRequest.OnHeadersReceived #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -53 lines) Patch
M chrome/browser/extensions/extension_webrequest_api.h View 1 2 3 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api.cc View 1 2 3 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_helpers.h View 1 2 3 4 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_helpers.cc View 1 2 3 6 chunks +95 lines, -22 lines 0 comments Download
M chrome/browser/extensions/extension_webrequest_api_unittest.cc View 1 2 3 4 chunks +447 lines, -10 lines 0 comments Download
M net/http/http_response_headers.h View 1 2 3 2 chunks +14 lines, -0 lines 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 2 chunks +45 lines, -0 lines 0 comments Download
M net/http/http_response_headers_unittest.cc View 1 2 3 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
battre
Hi Matt. Please review. Thanks. Dominic
9 years, 1 month ago (2011-11-10 15:39:34 UTC) #1
Matt Perry
lgtm
9 years, 1 month ago (2011-11-10 21:49:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8519003/4
9 years, 1 month ago (2011-11-11 09:17:57 UTC) #3
commit-bot: I haz the power
Change committed as 109609
9 years, 1 month ago (2011-11-11 10:22:25 UTC) #4
battre
9 years, 1 month ago (2011-11-11 13:00:39 UTC) #5
For the record if you stumble upon this CL in the future: Please ignore Patch
Set 4. This was uploaded incorrectly. Patch Set 3 was committed.

Powered by Google App Engine
This is Rietveld 408576698