Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: dart/tests/co19/testcfg.py

Issue 8518002: Handle co19 @dynamic-type-error better. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Don't use for-else Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tools/test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/co19/testcfg.py
diff --git a/dart/tests/co19/testcfg.py b/dart/tests/co19/testcfg.py
index f4250b9216aa0caffd8d877b07c0f5ba5b9f0d64..2732bb62ee0336a2cf68e2d6b5f6714f9a13efd9 100644
--- a/dart/tests/co19/testcfg.py
+++ b/dart/tests/co19/testcfg.py
@@ -27,15 +27,12 @@ class Co19TestCase(test.TestCase):
def IsNegative(self):
if self._is_negative is None :
contents = self.GetSource()
- for tag in ('@compile-error',
- # '@static-type-error',
- '@dynamic-type-error', '@runtime-error'):
- if tag in contents:
- self._is_negative = True
- break
- else :
+ if '@compile-error' in contents or '@runtime-error' in contents:
+ self._is_negative = True
+ elif '@dynamic-type-error' in contents:
+ self._is_negative = self.context.checked
+ else:
self._is_negative = False
-
return self._is_negative
def GetLabel(self):
« no previous file with comments | « dart/tests/co19/co19-runtime.status ('k') | dart/tools/test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698