Add support for --critical-update-version to installer.

Add support for --critical-update-version to installer.

The installer may now be given a --critical-update-version=W.X.Y.Z option on the command line.  If this is present for an in-use update and the indicated version is newer than the in-use Chrome, a new "cpv" value is dropped in the registry alongside "opv" and "cmd" (the other state associated with an in-use update).  Thanks to Finnur, Chrome will eventually notice that there's a pending critical update and do magical things to keep our users safe and secure.  Go users!

Other things I did while I was at it:
- switched version string conversions from UTF8ToWide to ASCIIToWide since version numbers are always ASCII dotted numbers.
- renamed the reg value from "CriticalUpdate" to "cpv" so it fits in nicely with the other cryptic values in the product's Clients key (a.k.a. Version key).

BUG=103526, 97665
TEST=Install version N, launch it with --check-for-update-interval=5, then install verison M>N with --critical-update-version=M.  After a few seconds, Chrome should do something fantastic.  Note that the alternate_version_generator can be used to create a newer versioned mini_installer from an existing one (just build it and run it).


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109620

[grt (UTC plus 2), 2011-11-10 19:31:52]

Looping in Finnur as a reviewer.

[robertshield, 2011-11-10 20:02:53]

On 2011/11/10 19:31:52, grt wrote:
> Looping in Finnur as a reviewer.

LGTM

[Finnur, 2011-11-11 10:31:01]

I can't verify the correctness of the patch, since I don't know the installer in
details, but I approve from a high-level standpoint and for changes to my code.

LGTM, with just general questions and nits.

http://codereview.chromium.org/8517012/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:560: // update relative to the version
being updated.
Is there a word missing or something from this comment? I can't make heads nor
tails of it.

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state.h (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.h:150: // - current_version == NULL or
current_version < CUV.
Wait... current_version can be NULL? How come? Is that the 'fresh install' case?

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.h:151: // - new_version >= CUV.
nit: Maybe use * for bullets instead of - so that "- --critical" doesn't look so
weird? :)

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state_unittest.cc (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state_unittest.cc:553: Version*
InstallerStateCriticalVersionTest::high_version_;
= NULL; ?

[grt (UTC plus 2), 2011-11-11 11:40:07]

Thanks.  PTAL.

http://codereview.chromium.org/8517012/diff/1/chrome/installer/setup/install_...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/setup/install_...
chrome/installer/setup/install_worker.cc:560: // update relative to the version
being updated.
On 2011/11/11 10:31:01, Finnur wrote:
> Is there a word missing or something from this comment? I can't make heads nor
> tails of it.

Uh, yeah . Updated.

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state.h (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.h:150: // - current_version == NULL or
current_version < CUV.
On 2011/11/11 10:31:01, Finnur wrote:
> Wait... current_version can be NULL? How come? Is that the 'fresh install'
case?

It's a case where the registry data for the current install is missing (due to
the user nuking registry keys, most likely).

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.h:151: // - new_version >= CUV.
On 2011/11/11 10:31:01, Finnur wrote:
> nit: Maybe use * for bullets instead of - so that "- --critical" doesn't look
so
> weird? :)

Done.

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state_unittest.cc (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state_unittest.cc:553: Version*
InstallerStateCriticalVersionTest::high_version_;
On 2011/11/11 10:31:01, Finnur wrote:
> = NULL; ?

C++ zero-initializes these during static initialization.  NULLs added to make it
obvious.

[Finnur, 2011-11-11 12:12:47]

Still LGTM. Thanks for the explanation.

Nits below...

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
File chrome/installer/util/installer_state.h (right):

http://codereview.chromium.org/8517012/diff/1/chrome/installer/util/installer...
chrome/installer/util/installer_state.h:150: // - current_version == NULL or
current_version < CUV.
I see.

On 2011/11/11 11:40:08, grt wrote:
> On 2011/11/11 10:31:01, Finnur wrote:
> > Wait... current_version can be NULL? How come? Is that the 'fresh install'
> case?
> 
> It's a case where the registry data for the current install is missing (due to
> the user nuking registry keys, most likely).

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:559: // critical_version will be valid
only if this in-use update contains a
nit: critical_version -> |critical_version|

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:560: // critical update relative to the
version being updated.
wording: Can you "contain something relative to something else"?

[grt (UTC plus 2), 2011-11-11 12:17:48]

Thanks.  Sending to the CQ now.

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:559: // critical_version will be valid
only if this in-use update contains a
On 2011/11/11 12:12:47, Finnur wrote:
> nit: critical_version -> |critical_version|

Done.

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:560: // critical update relative to the
version being updated.
On 2011/11/11 12:12:47, Finnur wrote:
> wording: Can you "contain something relative to something else"?

Done.

[commit-bot: I haz the power, 2011-11-11 12:18:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/grt@chromium.org/8517012/10003

[Finnur, 2011-11-11 12:25:38]

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
File chrome/installer/setup/install_worker.cc (right):

http://codereview.chromium.org/8517012/diff/9001/chrome/installer/setup/insta...
chrome/installer/setup/install_worker.cc:560: // critical update relative to the
version being updated.
Much better. Thanks.

On 2011/11/11 12:17:48, grt wrote:
> On 2011/11/11 12:12:47, Finnur wrote:
> > wording: Can you "contain something relative to something else"?
> 
> Done.

[commit-bot: I haz the power, 2011-11-11 13:28:35]

Change committed as 109620