chrome/browser/safe_browsing/client_side_detection_host_unittest.cc - Issue 8515027: Define the public version of the browser side RenderProcessHost interface. This interface is not ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

Issue 8515027: Define the public version of the browser side RenderProcessHost interface. This interface is not ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/client_side_detection_host.cc ('k') | chrome/browser/safe_browsing/client_side_detection_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/client_side_detection_host_unittest.cc

===================================================================

--- chrome/browser/safe_browsing/client_side_detection_host_unittest.cc (revision 110571)

+++ chrome/browser/safe_browsing/client_side_detection_host_unittest.cc (working copy)

@@ -265,7 +265,8 @@

virtual ~BogusClient() {}

};

resource.client = new BogusClient();

- resource.render_process_host_id = contents()->GetRenderProcessHost()->id();

+ resource.render_process_host_id = contents()->GetRenderProcessHost()->

+ GetID();

resource.render_view_id = contents()->render_view_host()->routing_id();

csd_host_->OnSafeBrowsingHit(resource);

delete resource.client;

@@ -412,7 +413,7 @@

EXPECT_FALSE(resource.is_subresource);

EXPECT_EQ(SafeBrowsingService::CLIENT_SIDE_PHISHING_URL,

resource.threat_type);

- EXPECT_EQ(contents()->GetRenderProcessHost()->id(),

+ EXPECT_EQ(contents()->GetRenderProcessHost()->GetID(),

resource.render_process_host_id);

EXPECT_EQ(contents()->render_view_host()->routing_id(),

resource.render_view_id);

@@ -508,7 +509,7 @@