Issue 8515025: Reland 109138 - GURL: Build the unit tests on the components build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8515025: Reland 109138 - GURL: Build the unit tests on the components build. (Closed)

Created:
9 years, 1 month ago by rvargas (doing something else)

Modified:
9 years, 1 month ago

Reviewers:
Nico

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reland 109138 - GURL: Build the unit tests on the components build. BUG=102738 TEST=none Review URL: http://codereview.chromium.org/8496034 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109552

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -9 lines)			Patch
	M	build/temp_gyp/googleurl.gyp	View		2 chunks	+1 line, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 1 month ago (2011-11-11 01:01:55 UTC) #2

lgtm stamp

On Thu, Nov 10, 2011 at 4:54 PM,  <rvargas@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Reland 109138 - GURL: Build the unit tests on the components build.
>
> BUG=102738
> TEST=none
>
> Review URL: http://codereview.chromium.org/8496034
>
> Please review this at http://codereview.chromium.org/8515025/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     build/temp_gyp/googleurl.gyp
>
>
> Index: build/temp_gyp/googleurl.gyp
> ===================================================================
> --- build/temp_gyp/googleurl.gyp        (revision 109550)
> +++ build/temp_gyp/googleurl.gyp        (working copy)
> @@ -67,6 +67,7 @@
>     },
>     {
>       'target_name': 'googleurl_unittests',
> +      'type': 'executable',
>       'dependencies': [
>         'googleurl',
>         '../../base/base.gyp:base_i18n',
> @@ -94,15 +95,6 @@
>             }],
>           ],
>         }],
> -        # TODO(victorw): The unittest code uses inline functions that
> access
> -        # global variables, it also uses internal functions that we may not
> want
> -        # to export, so skip building unittests for component builds.
> -        # The googleurl functions are tested by the static library build.
> -        ['component=="shared_library"', {
> -          'type': 'none',
> -        }, {
> -          'type': 'executable',
> -        }],
>       ],
>     },
>   ],
>
>
>

Expand Messages | Collapse Messages