tests/language/src/NonParameterizedFactoryTest.dart - Issue 8515024: Require legacy form of type parameters in factories and report errors if a factory class does not...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/language/src/NonParameterizedFactoryTest.dart

Issue 8515024: Require legacy form of type parameters in factories and report errors if a factory class does not... (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: '' Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/language/src/NonParameterizedFactoryTest.dart

===================================================================

--- tests/language/src/NonParameterizedFactoryTest.dart (revision 1435)

+++ tests/language/src/NonParameterizedFactoryTest.dart (working copy)

@@ -7,7 +7,8 @@

Interface.withArg(T value);

}

-class Factory {

+// A factory must be parametrized. Use legacy form.

ngeoffray 2011/11/11 10:09:44 parameterized. I don't understand the comment. Wh

ahe 2011/11/11 14:54:30 A factory *class* do not have to be parameterized.

+class Factory<T> {

ahe 2011/11/11 14:54:30 Remove the type variable.

srdjan 2011/11/11 16:33:39 Done.

factory Interface() {

ahe 2011/11/11 14:54:30 This should be: factory Interface<T>() {

srdjan 2011/11/11 16:33:39 Done.

return null;

}

« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »