Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: gpu/command_buffer/service/framebuffer_manager.cc

Issue 8515023: Allow deleted resources to be used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/framebuffer_manager.cc
diff --git a/gpu/command_buffer/service/framebuffer_manager.cc b/gpu/command_buffer/service/framebuffer_manager.cc
index 0ce9df075ec63e8553f2281c55cfccc673a153f9..7ca3e659ada5e75eefc957cb865772d42e8c1f58 100644
--- a/gpu/command_buffer/service/framebuffer_manager.cc
+++ b/gpu/command_buffer/service/framebuffer_manager.cc
@@ -49,6 +49,11 @@ class RenderbufferAttachment
return false;
}
+ virtual bool IsRenderbuffer(
+ RenderbufferManager::RenderbufferInfo* renderbuffer) const {
+ return renderbuffer_ == renderbuffer;
+ }
+
virtual bool CanRenderTo() const {
return true;
}
@@ -123,6 +128,11 @@ class TextureAttachment
return texture == texture_.get();
}
+ virtual bool IsRenderbuffer(
+ RenderbufferManager::RenderbufferInfo* /* renderbuffer */) const {
+ return false;
+ }
+
TextureManager::TextureInfo* texture() const {
return texture_.get();
}
@@ -284,6 +294,44 @@ bool FramebufferManager::FramebufferInfo::IsCleared() const {
return true;
}
+void FramebufferManager::FramebufferInfo::UnbindRenderbuffer(
+ GLenum target, RenderbufferManager::RenderbufferInfo* renderbuffer) {
+ bool done;
+ do {
+ done = true;
+ for (AttachmentMap::const_iterator it = attachments_.begin();
+ it != attachments_.end(); ++it) {
+ Attachment* attachment = it->second;
+ if (attachment->IsRenderbuffer(renderbuffer)) {
+ // TODO(gman): manually detach renderbuffer.
+ // glFramebufferRenderbufferEXT(target, it->first, GL_RENDERBUFFER, 0);
+ AttachRenderbuffer(it->first, NULL);
+ done = false;
+ break;
+ }
+ }
+ } while (!done);
+}
+
+void FramebufferManager::FramebufferInfo::UnbindTexture(
+ GLenum target, TextureManager::TextureInfo* texture) {
+ bool done;
+ do {
+ done = true;
+ for (AttachmentMap::const_iterator it = attachments_.begin();
+ it != attachments_.end(); ++it) {
+ Attachment* attachment = it->second;
+ if (attachment->IsTexture(texture)) {
+ // TODO(gman): manually detach texture.
+ // glFramebufferTexture2DEXT(target, it->first, GL_TEXTURE_2D, 0, 0);
+ AttachTexture(it->first, NULL, GL_TEXTURE_2D, 0);
+ done = false;
+ break;
+ }
+ }
+ } while (!done);
+}
+
FramebufferManager::FramebufferInfo* FramebufferManager::GetFramebufferInfo(
GLuint client_id) {
FramebufferInfoMap::iterator it = framebuffer_infos_.find(client_id);
« no previous file with comments | « gpu/command_buffer/service/framebuffer_manager.h ('k') | gpu/command_buffer/service/framebuffer_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698