Issue 8515023: Allow deleted resources to be used

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8515023: Allow deleted resources to be used (Closed)

Created:
9 years, 1 month ago by greggman

Modified:
9 years, 1 month ago

Reviewers:
apatrick_chromium

CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow deleted resources to be used This is to make the command buffer more OpenGL ES 2.0 spec compliant. Not that to work around bugs in drivers we will likely have to change all or some resources to not actually get deleted until the last reference is freed. That can wait for another CL TEST=unit tests and ran both ES and WebGL conformance tests BUG=102412 R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109612

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+327 lines, -66 lines)			Patch
M	gpu/command_buffer/service/buffer_manager.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.h	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager.cc	View	3 chunks	+48 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/framebuffer_manager_unittest.cc	View	1 chunk	+73 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	22 chunks	+110 lines, -43 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 chunk	+26 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	13 chunks	+7 lines, -15 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	3 chunks	+7 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager_unittest.cc	View	1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/8515023/1

9 years, 1 month ago (2011-11-11 09:46:24 UTC) #3

Change committed as 109612

Expand Messages | Collapse Messages