Move PluginPrefs to use PluginService instead of PluginList.

Move PluginPrefs to use PluginService instead of PluginList.

BUG=103788, chromium-os:22447
TEST=unit_tests --gtest_filter=PluginPrefs*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109657

[Robert Sesek, 2011-11-10 23:14:13]

Pri-1 code review.

[Bernhard Bauer, 2011-11-10 23:19:23]

LGTM with a suggestion below: (you're lucky I'm still awake ;-) )

http://codereview.chromium.org/8515021/diff/1/chrome/browser/plugin_prefs_uni...
File chrome/browser/plugin_prefs_unittest.cc (right):

http://codereview.chromium.org/8515021/diff/1/chrome/browser/plugin_prefs_uni...
chrome/browser/plugin_prefs_unittest.cc:37: base::ShadowingAtExitManager
at_exit_manager_;  // Destroys the PluginService.
You could move this down to PluginPrefsTest.DisableGlobally, to destroy the
PluginService as soon as possible.

[Robert Sesek, 2011-11-10 23:25:39]

+jam for OWNERS

http://codereview.chromium.org/8515021/diff/1/chrome/browser/plugin_prefs_uni...
File chrome/browser/plugin_prefs_unittest.cc (right):

http://codereview.chromium.org/8515021/diff/1/chrome/browser/plugin_prefs_uni...
chrome/browser/plugin_prefs_unittest.cc:37: base::ShadowingAtExitManager
at_exit_manager_;  // Destroys the PluginService.
On 2011/11/10 23:19:24, Bernhard Bauer wrote:
> You could move this down to PluginPrefsTest.DisableGlobally, to destroy the
> PluginService as soon as possible.

Done.

[jam, 2011-11-10 23:39:16]

http://codereview.chromium.org/8515021/diff/10/content/browser/plugin_service.cc
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/8515021/diff/10/content/browser/plugin_service...
content/browser/plugin_service.cc:647: if (plugin_list_)
this seems to be covering up for Init() not being called. We this function
should just return plugin_list_, and require callers to call Init() always.

[Robert Sesek, 2011-11-10 23:42:05]

http://codereview.chromium.org/8515021/diff/10/content/browser/plugin_service.cc
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/8515021/diff/10/content/browser/plugin_service...
content/browser/plugin_service.cc:647: if (plugin_list_)
On 2011/11/10 23:39:16, John Abd-El-Malek wrote:
> this seems to be covering up for Init() not being called. We this function
> should just return plugin_list_, and require callers to call Init() always.

Done.

[jam, 2011-11-10 23:57:40]

lgtm

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
content/browser/plugin_service.cc:647: return plugin_list_;
nit: please move this function impl to the header since it's just a simple
getter now :)

[Robert Sesek, 2011-11-11 01:19:19]

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
content/browser/plugin_service.cc:647: return plugin_list_;
On 2011/11/10 23:57:40, John Abd-El-Malek wrote:
> nit: please move this function impl to the header since it's just a simple
> getter now :)

Will do this in a follow-up tomorrow. Afk and want to cq.

[commit-bot: I haz the power, 2011-11-11 01:19:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/8515021/1003

[commit-bot: I haz the power, 2011-11-11 02:09:29]

Try job failure for 8515021-1003 (retry) on linux_rel for steps "unit_tests,
content_unittests".
It's a second try, previously, steps "unit_tests, content_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Robert Sesek, 2011-11-11 16:01:17]

Can either one of you take another look? Had to update some tests to call
PluginService::Init().

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
File content/browser/plugin_service.cc (right):

http://codereview.chromium.org/8515021/diff/1003/content/browser/plugin_servi...
content/browser/plugin_service.cc:647: return plugin_list_;
On 2011/11/11 01:19:19, rsesek wrote:
> On 2011/11/10 23:57:40, John Abd-El-Malek wrote:
> > nit: please move this function impl to the header since it's just a simple
> > getter now :)
> 
> Will do this in a follow-up tomorrow. Afk and want to cq.

Done.

[Bernhard Bauer, 2011-11-11 16:04:17]

LGTM!