Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 8515019: base::Bind: Convert most of webkit/appcache. (Closed)

Created:
9 years, 1 month ago by James Hawkins
Modified:
9 years, 1 month ago
Reviewers:
csilv
CC:
chromium-reviews, michaeln, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

base::Bind: Convert most of webkit/appcache. BUG=none TEST=none R=csilv@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109696

Patch Set 1 #

Total comments: 5

Patch Set 2 : Remove unused include. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -263 lines) Patch
M webkit/appcache/appcache_request_handler_unittest.cc View 10 chunks +25 lines, -19 lines 0 comments Download
M webkit/appcache/appcache_response_unittest.cc View 25 chunks +89 lines, -87 lines 0 comments Download
M webkit/appcache/appcache_storage_impl_unittest.cc View 31 chunks +76 lines, -70 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 15 chunks +50 lines, -44 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webkit/appcache/mock_appcache_storage.cc View 8 chunks +34 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Hawkins
9 years, 1 month ago (2011-11-10 23:03:46 UTC) #1
csilv
http://codereview.chromium.org/8515019/diff/1/webkit/appcache/appcache_group.cc File webkit/appcache/appcache_group.cc (right): http://codereview.chromium.org/8515019/diff/1/webkit/appcache/appcache_group.cc#newcode9 webkit/appcache/appcache_group.cc:9: #include "base/bind.h" I don't see a need for this ...
9 years, 1 month ago (2011-11-10 23:47:02 UTC) #2
James Hawkins
http://codereview.chromium.org/8515019/diff/1/webkit/appcache/appcache_group.cc File webkit/appcache/appcache_group.cc (right): http://codereview.chromium.org/8515019/diff/1/webkit/appcache/appcache_group.cc#newcode9 webkit/appcache/appcache_group.cc:9: #include "base/bind.h" On 2011/11/10 23:47:02, csilv wrote: > I ...
9 years, 1 month ago (2011-11-11 19:30:39 UTC) #3
csilv
9 years, 1 month ago (2011-11-11 19:33:47 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698