Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: chrome/browser/chromeos/login/webui_login_view.cc

Issue 8515011: Only clear Oobe errors on KeyDown to prevent clearing an immediate authentication error. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/webui_login_view.cc b/chrome/browser/chromeos/login/webui_login_view.cc
index d8d1c981f5bd8b5955856a6e0862474df9a5284a..9bf69a8e098469545b8da09b3958914e1fe9e4cd 100644
--- a/chrome/browser/chromeos/login/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/webui_login_view.cc
@@ -406,10 +406,13 @@ void WebUILoginView::HandleKeyboardEvent(const NativeWebKeyboardEvent& event) {
GetFocusManager());
// Make sure error bubble is cleared on keyboard event. This is needed
- // when the focus is inside an iframe.
- WebUI* web_ui = GetWebUI();
- if (web_ui)
- web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors");
+ // when the focus is inside an iframe. Only clear on KeyDown to prevent hiding
+ // an immediate authentication error (See crbug.com/103643).
+ if (event.type == WebKit::WebInputEvent::KeyDown) {
+ WebUI* web_ui = GetWebUI();
+ if (web_ui)
+ web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors");
+ }
}
} // namespace chromeos
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698