Issue 8515011: Only clear Oobe errors on KeyDown to prevent clearing an immediate authentication error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8515011: Only clear Oobe errors on KeyDown to prevent clearing an immediate authentication error. (Closed)

Created:
9 years, 1 month ago by flackr

Modified:
9 years, 1 month ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, Rick Byers

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only clear Oobe errors on KeyDown to prevent clearing an immediate authentication error. BUG=103643 TEST=Enable the WebUI lock screen, lock screen, enter an incorrect password and observe error message remains on screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109643

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/login/webui_login_view.cc	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/8515011/1

9 years, 1 month ago (2011-11-11 15:56:39 UTC) #3

Change committed as 109643

Expand Messages | Collapse Messages