A fix for LayerNoTextureSetFillsBoundsOpaquely.

A fix for LayerNoTextureSetFillsBoundsOpaquely.

Adds some omitted calls.

BUG=None
TEST=compositor_unittests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109630

[pkotwicz, 2011-11-10 19:20:52]

Looks good

[Ian Vollick, 2011-11-10 19:21:40]

+sky

[sky, 2011-11-10 20:20:52]

http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unit...
File ui/gfx/compositor/layer_unittest.cc (right):

http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unit...
ui/gfx/compositor/layer_unittest.cc:486: parent->SetFillsBoundsOpaquely(true);
Why should this matter if the layer has texture?

[Ian Vollick, 2011-11-10 20:34:14]

On 2011/11/10 20:20:52, sky wrote:
>
http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unit...
> File ui/gfx/compositor/layer_unittest.cc (right):
> 
>
http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unit...
> ui/gfx/compositor/layer_unittest.cc:486: parent->SetFillsBoundsOpaquely(true);
> Why should this matter if the layer has texture?

If the layer has no texture, SetFills.. shouldn't matter. I think that the
purpose of this test is to confirm that it really doesn't have an effect.

[sky, 2011-11-10 20:47:58]

Good point LGTM

[Antoine Labour, 2011-11-10 20:48:52]

On Thu, Nov 10, 2011 at 12:34 PM, <vollick@chromium.org> wrote:

> On 2011/11/10 20:20:52, sky wrote:
>
> http://codereview.chromium.**org/8515006/diff/1001/ui/gfx/**
>
compositor/layer_unittest.cc<http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unittest.cc>
>
>> File ui/gfx/compositor/layer_**unittest.cc (right):
>>
>
>
> http://codereview.chromium.**org/8515006/diff/1001/ui/gfx/**
>
compositor/layer_unittest.cc#**newcode486<http://codereview.chromium.org/8515006/diff/1001/ui/gfx/compositor/layer_unittest.cc#newcode486>
>
>> ui/gfx/compositor/layer_**unittest.cc:486: parent->**
>> SetFillsBoundsOpaquely(true);
>> Why should this matter if the layer has texture?
>>
>
> If the layer has no texture, SetFills.. shouldn't matter. I think that the
> purpose of this test is to confirm that it really doesn't have an effect.
>

Mmh, for the webkit compositor, the notion of "having a texture" or not is
moot.


>
>
http://codereview.chromium.**org/8515006/<http://codereview.chromium.org/8515...
>

[Ian Vollick, 2011-11-10 21:57:23]

> >
> > If the layer has no texture, SetFills.. shouldn't matter. I think that the
> > purpose of this test is to confirm that it really doesn't have an effect.
> >
> 
> Mmh, for the webkit compositor, the notion of "having a texture" or not is
> moot.
> 

I've flagged this test (and the other tests that don't apply to the webkit
compositor) so that they're DISABLED_.

Ian

[piman, 2011-11-10 22:03:33]

lgtm