Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: chrome/browser/ui/webui/task_manager_handler.cc

Issue 8515001: Revert 109394 - WebUI TaskManager: Add "Activate page" feature. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/task_manager_handler.h ('k') | chrome/browser/ui/webui/task_manager_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/task_manager_handler.cc
===================================================================
--- chrome/browser/ui/webui/task_manager_handler.cc (revision 109396)
+++ chrome/browser/ui/webui/task_manager_handler.cc (working copy)
@@ -120,8 +120,6 @@
}
if (column_name == "canInspect")
return Value::CreateBooleanValue(tm->CanInspect(i));
- if (column_name == "canActivate")
- return Value::CreateBooleanValue(tm->CanActivate(i));
NOTREACHED();
return NULL;
@@ -191,7 +189,6 @@
CreateGroupColumnList(tm, "goatsTeleported", index, length, val);
CreateGroupColumnList(tm, "goatsTeleportedValue", index, length, val);
CreateGroupColumnList(tm, "canInspect", index, length, val);
- CreateGroupColumnList(tm, "canActivate", index, length, val);
return val;
}
@@ -313,9 +310,6 @@
web_ui_->RegisterMessageCallback("inspect",
base::Bind(&TaskManagerHandler::HandleInspect,
base::Unretained(this)));
- web_ui_->RegisterMessageCallback("activatePage",
- base::Bind(&TaskManagerHandler::HandleActivatePage,
- base::Unretained(this)));
web_ui_->RegisterMessageCallback("openAboutMemory",
base::Bind(&TaskManagerHandler::OpenAboutMemory,
base::Unretained(this)));
@@ -357,25 +351,6 @@
}
}
-void TaskManagerHandler::HandleActivatePage(const ListValue* resource_index) {
- for (ListValue::const_iterator i = resource_index->begin();
- i != resource_index->end(); ++i) {
- int unique_id = parseIndex(*i);
- if (unique_id == -1)
- continue;
-
- for (int resource_index = 0; resource_index < model_->ResourceCount();
- ++resource_index) {
- if (model_->GetResourceUniqueId(resource_index) == unique_id) {
- task_manager_->ActivateProcess(resource_index);
- break;
- }
- }
-
- break;
- }
-}
-
void TaskManagerHandler::HandleInspect(const ListValue* resource_index) {
for (ListValue::const_iterator i = resource_index->begin();
i != resource_index->end(); ++i) {
« no previous file with comments | « chrome/browser/ui/webui/task_manager_handler.h ('k') | chrome/browser/ui/webui/task_manager_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698