Issue 8514004: Remove includes of worker_messages.h from chrome code, since that's an internal detail of content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8514004: Remove includes of worker_messages.h from chrome code, since that's an internal detail of content. (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
ananta

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dpranke-watch+content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove includes of worker_messages.h from chrome code, since that's an internal detail of content. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109746

Patch Set 1 #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+168 lines, -175 lines)			Patch
M	chrome/browser/about_flags.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.cc	View	3 chunks	+70 lines, -6 lines	0 comments	Download
D	chrome/browser/chrome_worker_message_filter.h	View	1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/chrome_worker_message_filter.cc	View	1 chunk	+0 lines, -96 lines	0 comments	Download
M	chrome/browser/ui/webui/workers_ui.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/mock_content_browser_client.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	content/browser/mock_content_browser_client.cc	View	2 chunks	+17 lines, -4 lines	0 comments	Download
M	content/browser/worker_host/worker_process_host.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/browser/worker_host/worker_process_host.cc	View	3 chunks	+8 lines, -4 lines	0 comments	Download
M	content/public/browser/content_browser_client.h	View	2 chunks	+18 lines, -5 lines	0 comments	Download
M	content/shell/shell_content_browser_client.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	content/shell/shell_content_browser_client.cc	View	2 chunks	+17 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ananta

9 years, 1 month ago (2011-11-12 00:10:15 UTC) #2

LGTM

http://codereview.chromium.org/8514004/diff/1/chrome/browser/ui/webui/workers...
File chrome/browser/ui/webui/workers_ui.cc (right):

http://codereview.chromium.org/8514004/diff/1/chrome/browser/ui/webui/workers...
chrome/browser/ui/webui/workers_ui.cc:155: WorkerProcessHost* worker =
static_cast<WorkerProcessHost*>(*iter);
Please fix indent.

Expand Messages | Collapse Messages