Issue 8513020: base::Bind migrations in chrome/browser

Issue 8513020: base::Bind migrations in chrome/browser (Closed)

Created:
9 years, 1 month ago by csilv

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, James Hawkins

CC:
chromium-reviews, yoshiki+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

base::Bind migrations in chrome/browser BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110561

Patch Set 3 : review fix #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -34 lines)			Patch
M	chrome/browser/task_manager/task_manager.cc	View		4 chunks	+8 lines, -11 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View		4 chunks	+12 lines, -7 lines	0 comments	Download
M	chrome/browser/upgrade_detector_impl.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/upgrade_detector_impl.cc	View	1 2	6 chunks	+11 lines, -9 lines	1 comment	Download
M	chrome/browser/visitedlink/visitedlink_master.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM with semi-nit. http://codereview.chromium.org/8513020/diff/5001/chrome/browser/upgrade_detector_impl.cc File chrome/browser/upgrade_detector_impl.cc (right): http://codereview.chromium.org/8513020/diff/5001/chrome/browser/upgrade_detector_impl.cc#newcode71 chrome/browser/upgrade_detector_impl.cc:71: DetectUpgradeTask(base::Closure upgrade_detected_task, const base::Closure&

9 years, 1 month ago (2011-11-16 22:31:36 UTC) #2

csilv

http://codereview.chromium.org/8513020/diff/5001/chrome/browser/upgrade_detector_impl.cc File chrome/browser/upgrade_detector_impl.cc (right): http://codereview.chromium.org/8513020/diff/5001/chrome/browser/upgrade_detector_impl.cc#newcode71 chrome/browser/upgrade_detector_impl.cc:71: DetectUpgradeTask(base::Closure upgrade_detected_task, On 2011/11/16 22:31:36, James Hawkins wrote: > ...

9 years, 1 month ago (2011-11-16 22:43:23 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csilv@chromium.org/8513020/9001

9 years, 1 month ago (2011-11-17 02:38:35 UTC) #4

Mark Mentovai

Chris, can you take a closer look at your change? The canary just notified me ...

9 years, 1 month ago (2011-11-18 19:50:58 UTC) #5

Mark Mentovai

http://codereview.chromium.org/8513020/diff/9001/chrome/browser/upgrade_detector_impl.cc File chrome/browser/upgrade_detector_impl.cc (right): http://codereview.chromium.org/8513020/diff/9001/chrome/browser/upgrade_detector_impl.cc#newcode83 chrome/browser/upgrade_detector_impl.cc:83: upgrade_detected_task_); Aha! In the DetectUpgradeTask destructor, you’re posting the ...

9 years, 1 month ago (2011-11-18 20:27:45 UTC) #6

csilv

9 years, 1 month ago (2011-11-18 20:59:48 UTC) #8

On 2011/11/18 20:30:08, Mark Mentovai wrote:
> http://crbug.com/104790.

Yeah, one I took a second look the my error was pretty obvious (and dumb).  Fix
coming shortly.

Expand Messages | Collapse Messages