Issue 8513007: [cros] Use LoginDisplayHost::GetNativeWindow() for status area on login screen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8513007: [cros] Use LoginDisplayHost::GetNativeWindow() for status area on login screen (Closed)

Created:
9 years, 1 month ago by Nikita (slow)

Modified:
9 years, 1 month ago

Reviewers:
stevenjb, altimofeev

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, stevenjb

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[cros] Use LoginDisplayHost::GetNativeWindow() for status area on login screen. Regression after http://codereview.chromium.org/8438064 since on login screen status area parent widget is small window. Also remove keyboard_switch_menu.* BUG=chromium-os:22929, chromium:99545 TEST=All dialogs initiated at login screen from status area are displayed in center. TBR=stevenjb@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110672

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -124 lines)			Patch
D	chrome/browser/chromeos/login/keyboard_switch_menu.h	View		1 chunk	+0 lines, -45 lines	0 comments	Download
D	chrome/browser/chromeos/login/keyboard_switch_menu.cc	View		1 chunk	+0 lines, -74 lines	0 comments	Download
M	chrome/browser/chromeos/login/network_screen.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu_button.cc	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

Nikita (slow)

Steven, please take a look at changes in network_menu_button.cc

9 years, 1 month ago (2011-11-16 16:47:35 UTC) #3

Steven, need owner LGTM for chromeos/status/