Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Unified Diff: frog/leg/ssa/nodes.dart

Issue 8513004: Throw and a small fix to If. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Change diff-base Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/leg/ssa/nodes.dart
diff --git a/frog/leg/ssa/nodes.dart b/frog/leg/ssa/nodes.dart
index c326b5f129002133e44b2e4fd597ea66705e3a3f..d0acbe6203d3e5129555526592e621a33594978a 100644
--- a/frog/leg/ssa/nodes.dart
+++ b/frog/leg/ssa/nodes.dart
@@ -17,6 +17,7 @@ interface HVisitor<R> {
R visitSubtract(HSubtract node);
R visitMultiply(HMultiply node);
R visitReturn(HReturn node);
+ R visitThrow(HThrow node);
R visitTruncatingDivide(HTruncatingDivide node);
}
@@ -155,20 +156,22 @@ class HBaseVisitor extends HGraphVisitor implements HVisitor {
visitInstruction(HInstruction) {}
visitArithmetic(HArithmetic node) => visitInvoke(node);
+ visitControlFlow(HControlFlow node) => visitInstruction(node);
visitAdd(HAdd node) => visitArithmetic(node);
visitDivide(HDivide node) => visitArithmetic(node);
- visitExit(HExit node) => visitInstruction(node);
- visitGoto(HGoto node) => visitInstruction(node);
- visitIf(HIf node) => visitInstruction(node);
+ visitExit(HExit node) => visitControlFlow(node);
+ visitGoto(HGoto node) => visitControlFlow(node);
+ visitIf(HIf node) => visitControlFlow(node);
visitInvoke(HInvoke node) => visitInstruction(node);
visitInvokeForeign(HInvokeForeign node) => visitInvoke(node);
visitLiteral(HLiteral node) => visitInstruction(node);
visitPhi(HPhi node) => visitInstruction(node);
visitMultiply(HMultiply node) => visitArithmetic(node);
visitParameter(HParameter node) => visitInstruction(node);
- visitReturn(HReturn node) => visitInstruction(node);
+ visitReturn(HReturn node) => visitControlFlow(node);
visitSubtract(HSubtract node) => visitArithmetic(node);
+ visitThrow(HThrow node) => visitControlFlow(node);
visitTruncatingDivide(HTruncatingDivide node) => visitArithmetic(node);
}
@@ -474,6 +477,11 @@ class HInstruction {
}
}
+class HControlFlow extends HInstruction {
+ HControlFlow(inputs) : super(inputs);
+ abstract toString();
+}
+
class HInvoke extends HInstruction {
final SourceString selector;
HInvoke(this.selector, inputs) : super(inputs);
@@ -546,19 +554,19 @@ class HTruncatingDivide extends HArithmetic {
bool dataEquals(HInstruction other) => true;
}
-class HExit extends HInstruction {
+class HExit extends HControlFlow {
HExit() : super(const <HInstruction>[]);
toString() => 'exit';
accept(HVisitor visitor) => visitor.visitExit(this);
}
-class HGoto extends HInstruction {
+class HGoto extends HControlFlow {
HGoto() : super(const <HInstruction>[]);
toString() => 'goto';
accept(HVisitor visitor) => visitor.visitGoto(this);
}
-class HIf extends HInstruction {
+class HIf extends HControlFlow {
bool hasElse;
HIf(HInstruction condition, this.hasElse) : super(<HInstruction>[condition]);
toString() => 'if';
@@ -597,8 +605,14 @@ class HPhi extends HInstruction {
accept(HVisitor visitor) => visitor.visitPhi(this);
}
-class HReturn extends HInstruction {
+class HReturn extends HControlFlow {
HReturn(value) : super([value]);
toString() => 'return';
accept(HVisitor visitor) => visitor.visitReturn(this);
}
+
+class HThrow extends HControlFlow {
+ HThrow(value) : super([value]);
ngeoffray 2011/11/10 13:22:37 does it still hold if value is null?
+ toString() => 'throw';
+ accept(HVisitor visitor) => visitor.visitThrow(this);
+}

Powered by Google App Engine
This is Rietveld 408576698