Throw and a small fix to If.

frog/leg/ssa/builder.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaBuilderTask extends CompilerTask {
   SsaBuilderTask(Compiler compiler) : super(compiler);
   String get name() => 'SSA builder';
 
   HGraph build(Node tree, Map<Node, Element> elements) {
     return measure(() {
@@ skipping 202 matching lines @@
       block = null;
     } else {
       block = joinBlock;
       if (thenBlockJoined && elseBlockJoined) {
         thenExitBlock.addGoto(graph, joinBlock);
         if (hasElse) elseExitBlock.addGoto(graph, joinBlock);
         definitions =
             joinDefinitions(joinBlock, thenDefinitions, elseDefinitions);
       } else if (thenBlockJoined) {
         thenExitBlock.addGoto(graph, joinBlock);
-      } else if (elseBlockJoined) {
+      } else if (elseBlockJoined && hasElse) {
         elseExitBlock.addGoto(graph, joinBlock);
       }
     }
   }
 
   SourceString unquote(LiteralString literal) {
     String str = '${literal.value}';
     compiler.ensure(str[0] == '@');
     int quotes = 1;
     String quote = str[1];
@@ skipping 84 matching lines @@
   visitReturn(Return node) {
     visit(node.expression);
     var value = pop();
     add(new HReturn(value));
     graph.setSuccessors(block, <HBasicBlock>[graph.exit]);
     // A return aborts the building of the current block.
     block = null;
   }
 
   visitThrow(Throw node) {
-    compiler.unimplemented("SsaBuilder.visitThrow");
+    visit(node.expression);

[ngeoffray, 2011/11/10 13:22:37]

Note that expression may be null.

[floitsch, 2011/11/10 14:02:22]

Done.

+    add(new HThrow(pop()));
+    // A throw aborts the building of the current block.
+    block = null;
   }
 
   visitTypeAnnotation(TypeAnnotation node) {
     // We currently ignore type annotations for generating code.
   }
 
   HInstruction updateDefinition(SendSet node) {
     if (node.receiver != null) {
       compiler.unimplemented("SsaBuilder: property access");
     }
@@ skipping 12 matching lines @@
       if (definition is Identifier) {
         compiler.unimplemented(
             "SsaBuilder.visitVariableDefinitions without initial value");
       } else {
         assert(definition is SendSet);
         updateDefinition(definition);
       }
     }
   }
 }