Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text before pasting

chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc

Index: chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	(revision 109588)
+++ chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	(working copy)
@@ -1445,6 +1445,8 @@
   GtkClipboard* x_clipboard = gtk_clipboard_get(GDK_SELECTION_CLIPBOARD);
   gchar* text = gtk_clipboard_wait_for_text(x_clipboard);
   string16 text_wstr = UTF8ToUTF16(text ? text : "");
+  string16 text_stripped =
+      CollapseWhitespace(StripJavascriptSchemas(text_wstr), true);

[Peter Kasting, 2011/11/15 06:52:22]

You need to reverse the CollapseWhitespace and StripJavascriptSchemas calls as
in omnibox_view_{mac.mm,win.cc}.

Nit: Combine this with the line above as:

  string16 sanitized_text(text ?
      StripJavascriptSchemas(CollapseWhitespace(UTF8ToUTF16(text))) :
      string16());

[SanjoyPal, 2011/11/15 07:11:15]

Done.

   g_free(text);
 
   // Paste and Go menu item.
@@ -1456,7 +1458,7 @@
   g_signal_connect(paste_go_menuitem, "activate",
                    G_CALLBACK(HandlePasteAndGoThunk), this);
   gtk_widget_set_sensitive(paste_go_menuitem,
-                           model_->CanPasteAndGo(text_wstr));
+                           model_->CanPasteAndGo(text_stripped));
   gtk_widget_show(paste_go_menuitem);
 
   g_signal_connect(menu, "deactivate",