Issue 8511083: Add arguments in macros where required

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511083: Add arguments in macros where required (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
robertshield, slightlyoff, amit, ananta, tommi (sloooow) - chröme

CC:
chromium-reviews, amit, robertshield

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add arguments in macros where required This was breaking a variant of the current macro, so I defined a no-op for the "code" values. r=slightlyoff BUG=103830 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110585

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -20 lines)			Patch
	M	chrome_frame/chrome_frame_delegate.cc	View		1 chunk	+26 lines, -20 lines	0 comments	Download

Total messages: 3 (0 generated)

jar (doing other things)

Looking for a rubber stamp from an OWNER.

9 years, 1 month ago (2011-11-17 22:44:45 UTC) #2

lgtm