Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 8511068: Initialize clip_rect_ member to be empty until explicitly set. (Closed)

Created:
9 years, 1 month ago by Wez
Modified:
9 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
cbentzel, chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Initialize clip_rect_ member to be empty until explicitly set. BUG=98751 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/base/decoder_vp8.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Wez
This should allow the DecoderVp8::ConvertRects suppression to be removed.
9 years, 1 month ago (2011-11-11 20:49:21 UTC) #1
Sergey Ulanov
LGTM. It looks wrong to me that SkIRect doesn't initialize itself.
9 years, 1 month ago (2011-11-11 21:21:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/8511068/1
9 years, 1 month ago (2011-11-11 21:41:22 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 23:35:13 UTC) #4
Change committed as 109731

Powered by Google App Engine
This is Rietveld 408576698