Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 8511067: Remove GPU blacklist auto-update. (Closed)

Created:
9 years, 1 month ago by Zhenyao Mo
Modified:
9 years, 1 month ago
CC:
chromium-reviews, jam, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove GPU blacklist auto-update. Also, use the software_rendering_list.json in deps, so it can be shared by all branches and main trunk. Note that this CL is the minimum because we need to merge back to M16. The remaining cleanup, including removing the dead code, simplifying GpuDataManager, refactoring, will be done in a separate CL. BUG=103851 TEST=try bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109738

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -448 lines) Patch
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/software_rendering_list.json View 1 chunk +0 lines, -446 lines 0 comments Download
M chrome/browser/web_resource/gpu_blacklist_updater.cc View 1 chunk +0 lines, -1 line 1 comment Download
M content/browser/gpu/gpu_blacklist_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
Please review.
9 years, 1 month ago (2011-11-11 19:32:46 UTC) #1
Ken Russell (switch to Gerrit)
LGTM http://codereview.chromium.org/8511067/diff/1/chrome/browser/web_resource/gpu_blacklist_updater.cc File chrome/browser/web_resource/gpu_blacklist_updater.cc (left): http://codereview.chromium.org/8511067/diff/1/chrome/browser/web_resource/gpu_blacklist_updater.cc#oldcode117 chrome/browser/web_resource/gpu_blacklist_updater.cc:117: updater->StartAfterDelay(); Is there a larger code simplification that ...
9 years, 1 month ago (2011-11-11 20:53:42 UTC) #2
Zhenyao Mo
9 years, 1 month ago (2011-11-12 00:13:58 UTC) #3
On 2011/11/11 20:53:42, kbr wrote:
> LGTM
> 
>
http://codereview.chromium.org/8511067/diff/1/chrome/browser/web_resource/gpu...
> File chrome/browser/web_resource/gpu_blacklist_updater.cc (left):
> 
>
http://codereview.chromium.org/8511067/diff/1/chrome/browser/web_resource/gpu...
> chrome/browser/web_resource/gpu_blacklist_updater.cc:117:
> updater->StartAfterDelay();
> Is there a larger code simplification that can be made given this policy
change?
> If so, could you file a bug to do it?

Yes we can simply a lot of code.  I will keep track of this in the same bug
until all dead code is removed.

Powered by Google App Engine
This is Rietveld 408576698