Move GetCharacterFromKeyCode from views::KeyEvent to ui/base/keycodes/keyboard_code_conversion.h.

views/events/event.h

Index: views/events/event.h
diff --git a/views/events/event.h b/views/events/event.h
index a7b3620b08c92ae3fe470e467892fc988b23db67..9939718a91848d8277606317e0a415060f5eb132 100644
--- a/views/events/event.h
+++ b/views/events/event.h
@@ -334,28 +334,8 @@ class VIEWS_EXPORT KeyEvent : public Event {
   uint16 GetUnmodifiedCharacter() const;
 
  private:
-  // A helper function to get the character generated by a key event in a
-  // platform independent way. It supports control characters as well.
-  // It assumes a US keyboard layout is used, so it may only be used when there
-  // is no native event or no better way to get the character.
-  // For example, if a virtual keyboard implementation can only generate key
-  // events with key_code and flags information, then there is no way for us to
-  // determine the actual character that should be generate by the key. Because
-  // a key_code only represents a physical key on the keyboard, it has nothing
-  // to do with the actual character printed on that key. In such case, the only
-  // thing we can do is to assume that we are using a US keyboard and get the
-  // character according to US keyboard layout definition.
-  // If a virtual keyboard implementation wants to support other keyboard
-  // layouts, that may generate different text for a certain key than on a US
-  // keyboard, a special native event object should be introduced to carry extra
-  // information to help determine the correct character.
-  // Take XKeyEvent as an example, it contains not only keycode and modifier
-  // flags but also group and other extra XKB information to help determine the
-  // correct character. That's why we can use XLookupString() function to get
-  // the correct text generated by a X key event (See how is GetCharacter()
-  // implemented in event_x.cc).
-  // TODO(suzhe): define a native event object for virtual keyboard. We may need
-  // to take the actual feature requirement into account.
+  // See GetCharacterFromKeyCode in ui/base/keycodes/keyboard_code_conversion.h
+  // for details.
   static uint16 GetCharacterFromKeyCode(ui::KeyboardCode key_code, int flags);

[sky, 2011/11/15 16:00:27]

Can we remove this and use the one you're adding to ui/base?

[Yusuke Sato, 2011/11/16 01:14:21]

Done.

 
   ui::KeyboardCode key_code_;