Issue 8511059: [cros, Aura] Fix login screen crash on boot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8511059: [cros, Aura] Fix login screen crash on boot. (Closed)

Created:
9 years, 1 month ago by Nikita (slow)

Modified:
9 years, 1 month ago

Reviewers:
stevenjb, DaveMoore

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros, Aura] Fix login screen crash on boot. Crash was caused by the uninitialized ScreenAura instance used in chromeos::CalculateScreenBounds chrome/browser/chromeos/login/helper.cc:164 Moved initialization of login screen classes right before message loop start so that Desktop/Screen instances are initialized. Also fixed crash during sign in. BUG=103892 TEST=Boot with Aura build, sign in. No crashes

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download
	M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

Feel free to check commit checkbox. I'll be offline for several hours.

9 years, 1 month ago (2011-11-11 17:47:45 UTC) #2

stevenjb

LGTM The aura tests are failing on ToT, so I will go ahead and commit ...

9 years, 1 month ago (2011-11-11 18:45:03 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/8511059/1

9 years, 1 month ago (2011-11-11 18:45:20 UTC) #4

oshima

9 years, 1 month ago (2011-11-11 19:05:52 UTC) #5

On 2011/11/11 18:45:20, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
> https://chromium-status.appspot.com/cq/nkostylev%40chromium.org/8511059/1

Since this is crasher, I'll just commit it manually.

Expand Messages | Collapse Messages