Export symbols from content.dll that are depended upon by chrome.dll.

Export symbols from content.dll that are depended upon by chrome.dll. 

BUG=103896
TBR=dpranke
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109622

[Jói, 2011-11-11 13:09:36]

LGTM, with a question.

Thanks for taking care of this.

Cheers,
Jói

http://codereview.chromium.org/8511058/diff/4001/content/renderer/renderer_gl...
File content/renderer/renderer_glue.cc (right):

http://codereview.chromium.org/8511058/diff/4001/content/renderer/renderer_gl...
content/renderer/renderer_glue.cc:95: CONTENT_EXPORT ui::Clipboard*
ClipboardGetClipboard() {
Should these be in the header file (webkit/glue/webkit_glue.h) instead, or would
that ruin it for others implementing that header?

[tommi (sloooow) - chröme, 2011-11-11 13:23:29]

http://codereview.chromium.org/8511058/diff/4001/content/renderer/renderer_gl...
File content/renderer/renderer_glue.cc (right):

http://codereview.chromium.org/8511058/diff/4001/content/renderer/renderer_gl...
content/renderer/renderer_glue.cc:95: CONTENT_EXPORT ui::Clipboard*
ClipboardGetClipboard() {
On 2011/11/11 13:09:36, Jói wrote:
> Should these be in the header file (webkit/glue/webkit_glue.h) instead, or
would
> that ruin it for others implementing that header?

Yes, they should only be in the header. Fixing.

[jam, 2011-11-11 17:17:00]

whoa, this shouldn't have been commmitted. webkit can't include content.

[Jói, 2011-11-11 17:19:28]

Hi John,

It's a temporary hack to fix the components build.  The only file that
Tommi let webkit depend on was content_export.h, which is just a
couple of defines.  There is a bug to track fixing this properly, it's
mentioned in the TODO in the DEPS file.

Cheers,
Jói


On Fri, Nov 11, 2011 at 5:17 PM,  <jam@chromium.org> wrote:
> whoa, this shouldn't have been commmitted. webkit can't include content.
>
> http://codereview.chromium.org/8511058/
>

[jam, 2011-11-11 17:23:49]

If there's a problem with the content dll, then we can revert turning it on in
the meantime. This has already happened a few times, esp because of issues with
webkit.

DEPS rules shouldn't be circumvented, even temporarily.
http://www.chromium.org/developers/content-module gives a high level view of the
chrome dependencies, and since content is above webkit, it can consume, it, but
not the other way around.

On 2011/11/11 17:19:28, Jói wrote:
> Hi John,
> 
> It's a temporary hack to fix the components build.  The only file that
> Tommi let webkit depend on was content_export.h, which is just a
> couple of defines.  There is a bug to track fixing this properly, it's
> mentioned in the TODO in the DEPS file.
> 
> Cheers,
> Jói
> 
> 
> On Fri, Nov 11, 2011 at 5:17 PM,  <mailto:jam@chromium.org> wrote:
> > whoa, this shouldn't have been commmitted. webkit can't include content.
> >
> > http://codereview.chromium.org/8511058/
> >

[jam, 2011-11-11 17:26:43]

just saw that the change was already reverted (but I can't see the reason on the
cl desc?), so I guess we're ok now.

it's taken a lot of effort and time to do the ocntent.dll, so if we revert it
for a few days, that's totally fine :)

[tommi (sloooow) - chröme, 2011-11-11 18:05:37]

Thanks Joi and John - So, I was hoping that I could fix the build error
before MTV woke up, but there were simply too many things that were still
broken (multiple webkit related projects), so I reverted.  The shared bot
hung green though, so I guess next time we enable content.dll we should
clobber to make sure.

On Fri, Nov 11, 2011 at 6:26 PM, <jam@chromium.org> wrote:

> just saw that the change was already reverted (but I can't see the reason
> on the
> cl desc?), so I guess we're ok now.
>
> it's taken a lot of effort and time to do the ocntent.dll, so if we revert
> it
> for a few days, that's totally fine :)
>
>
http://codereview.chromium.**org/8511058/<http://codereview.chromium.org/8511...
>

[Dirk Pranke, 2011-11-11 19:54:52]

Thanks for trying to fix this Tommi! As you've figured out, getting it
right is annoyingly complicated. I'm very puzzled that a non-clobber
build worked for me (and on the bots) but the clobber build didn't, as
I do clobber builds locally all the time. At any rate, I'm looking
into it now and hopefully it won't be too hard to fix correctly.

-- Dirk

On Fri, Nov 11, 2011 at 10:05 AM, Tommi <tommi@chromium.org> wrote:
> Thanks Joi and John - So, I was hoping that I could fix the build error
> before MTV woke up, but there were simply too many things that were still
> broken (multiple webkit related projects), so I reverted.  The shared bot
> hung green though, so I guess next time we enable content.dll we should
> clobber to make sure.
> On Fri, Nov 11, 2011 at 6:26 PM, <jam@chromium.org> wrote:
>>
>> just saw that the change was already reverted (but I can't see the reason
>> on the
>> cl desc?), so I guess we're ok now.
>>
>> it's taken a lot of effort and time to do the ocntent.dll, so if we revert
>> it
>> for a few days, that's totally fine :)
>>
>> http://codereview.chromium.org/8511058/
>
>