Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 8511055: Remove old history UI, and replace with history2. (Closed)

Created:
9 years, 1 month ago by Patrick Dubroy
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Nirnimesh, John Grabowski, arv (Not doing code reviews), dyu1, Paweł Hajdan Jr., dennis_jeffrey, anantha
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove old history UI, and replace with history2. chrome://history will now show the page that used to appear at chrome://history2. BUG=52697, 76595 TEST=Manual. Go to chrome://history and ensure that the new UI is displayed (there is no more "Edit items..." link in the top right). Verify that deleting a single item using the action menu works, and verify that deleting multiple items using the "Remove selected items" button works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110278

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Suppress bidichecker test failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -2287 lines) Patch
M chrome/browser/browser_resources.grd View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/history.html View 1 5 chunks +173 lines, -56 lines 0 comments Download
M chrome/browser/resources/history.js View 27 chunks +333 lines, -273 lines 0 comments Download
D chrome/browser/resources/history2.html View 1 1 chunk +0 lines, -268 lines 0 comments Download
D chrome/browser/resources/history2.js View 1 chunk +0 lines, -1133 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_factory.cc View 1 3 chunks +0 lines, -6 lines 0 comments Download
D chrome/browser/ui/webui/history2_ui.h View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/ui/webui/history2_ui.cc View 1 chunk +0 lines, -406 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 10 chunks +47 lines, -21 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/webui/bidichecker_tests.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/functional/special_tabs.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Patrick Dubroy
Jochen, can you please review? There should be no functionality changes here besides changing the ...
9 years, 1 month ago (2011-11-11 09:48:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm
9 years, 1 month ago (2011-11-14 16:06:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/8511055/6001
9 years, 1 month ago (2011-11-16 08:31:14 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-16 10:19:45 UTC) #4
Change committed as 110278

Powered by Google App Engine
This is Rietveld 408576698