Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 8511052: ARM: Check that address given to __ RecordWrite is correct. (Closed)

Created:
9 years, 1 month ago by Erik Corry
Modified:
9 years, 1 month ago
CC:
v8-dev
Visibility:
Public.

Description

ARM: Check that address given to __ RecordWrite is correct. Committed: http://code.google.com/p/v8/source/detail?r=9963

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Erik Corry
9 years, 1 month ago (2011-11-11 08:12:04 UTC) #1
danno
lgtm
9 years, 1 month ago (2011-11-11 08:22:31 UTC) #2
Kevin Millikin (Chromium)
http://codereview.chromium.org/8511052/diff/1002/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/8511052/diff/1002/src/arm/macro-assembler-arm.cc#newcode486 src/arm/macro-assembler-arm.cc:486: if (FLAG_debug_code) { We don't use FLAG_debug_code in the ...
9 years, 1 month ago (2011-11-11 11:28:37 UTC) #3
Kevin Millikin (Chromium)
9 years, 1 month ago (2011-11-11 11:32:22 UTC) #4
http://codereview.chromium.org/8511052/diff/1002/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/8511052/diff/1002/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:490: b(eq, &ok);
Also, while I think of it, is there a reason not to use

Check(eq, "Wrong address or value passed to RecordWrite")

?

Powered by Google App Engine
This is Rietveld 408576698