crypto/encryptor.cc - Issue 8511050: Unify the error checking of crypto::Encryptor and add WARN_UNUSED_RESULT to prevent misuse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/encryptor.cc

Issue 8511050: Unify the error checking of crypto::Encryptor and add WARN_UNUSED_RESULT to prevent misuse. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix typo Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/encryptor.cc

diff --git a/crypto/encryptor.cc b/crypto/encryptor.cc

index 31a7cc830a45d0c4a65de0bfe65262437270793e..984da1fb029f6c3e93f9c05752a9973f2d3a857e 100644

--- a/crypto/encryptor.cc

+++ b/crypto/encryptor.cc

@@ -66,7 +66,8 @@ bool Encryptor::GenerateCounterMask(size_t plaintext_len,

const size_t kBlockLength = counter_->GetLengthInBytes();

size_t blocks = (plaintext_len + kBlockLength - 1) / kBlockLength;

- CHECK(blocks);

+ if (blocks == 0)

+ return false;

*mask_len = blocks * kBlockLength;

« no previous file with comments | « crypto/encryptor.h ('k') | crypto/encryptor_mac.cc » ('j') | no next file with comments »