net/socket/dns_cert_provenance_checker.cc - Issue 8511050: Unify the error checking of crypto::Encryptor and add WARN_UNUSED_RESULT to prevent misuse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/dns_cert_provenance_checker.cc

Issue 8511050: Unify the error checking of crypto::Encryptor and add WARN_UNUSED_RESULT to prevent misuse. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix mac and linux Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/dns_cert_provenance_checker.cc

diff --git a/net/socket/dns_cert_provenance_checker.cc b/net/socket/dns_cert_provenance_checker.cc

index b05a38260eb6b0e83996229d1377502603d14f76..385762d20b56704fbd3028871f568d99d8e08410 100644

--- a/net/socket/dns_cert_provenance_checker.cc

+++ b/net/socket/dns_cert_provenance_checker.cc

@@ -312,7 +312,8 @@ std::string DnsCertProvenanceChecker::BuildEncryptedReport(

std::string plaintext(reinterpret_cast<const char*>(p.data()), p.size());

std::string ciphertext;

- encryptor.Encrypt(plaintext, &ciphertext);

+ r = encryptor.Encrypt(plaintext, &ciphertext);

+ CHECK(r);

// We use another Pickle object to serialise the 'outer' wrapping of the

// plaintext.

« crypto/encryptor_nss.cc ('K') | « crypto/encryptor_win.cc ('k') | no next file » | no next file with comments »