Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8511046: deprecate webui.css (Closed)

Created:
9 years, 1 month ago by Evan Stade
Modified:
9 years, 1 month ago
CC:
chromium-reviews, asanka, arv (Not doing code reviews), nkostylev+watch_chromium.org, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

deprecate webui.css This file is really only useful to downloads and history. All other includes of the file are senseless copy-pasta as far as I can tell. There is also the problem that due to its poor name, it became a dumping ground for generic stuff like displaytable, and then was included into chrome://settings because of it. Move out the bits that should live elsewhere, remove the rules that are not used anywhere, rename the file to head off re-use. Also move gpu_internals stuff into gpu_internals/, and remove completely duplicated file webui2.css. BUG=103688 TEST=manually checking gpu internals, media internals, policy, tracing, options, history, downloads Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109765

Patch Set 1 #

Patch Set 2 : undo mistake in downloads #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -304 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/bug_report.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/downloads.html View 1 3 chunks +1 line, -36 lines 2 comments Download
D chrome/browser/resources/gpu_internals.html View 1 chunk +0 lines, -74 lines 0 comments Download
chrome/browser/resources/gpu_internals.js View 1 chunk +0 lines, -42 lines 0 comments Download
A + chrome/browser/resources/gpu_internals/gpu_internals.html View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/resources/gpu_internals/gpu_internals.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/history.html View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/history2.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/media_internals.html View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/resources/old_webui.css View 3 chunks +7 lines, -28 lines 2 comments Download
M chrome/browser/resources/options/options.html View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/options_page.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/policy.html View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/shared/css/button.css View 1 chunk +12 lines, -6 lines 0 comments Download
M chrome/browser/resources/sync_promo.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/tracing.html View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/resources/webui.css View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/resources/webui2.css View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Evan Stade
9 years, 1 month ago (2011-11-10 05:57:20 UTC) #1
Dan Beam
lgtm http://codereview.chromium.org/8511046/diff/1022/chrome/browser/resources/downloads.html File chrome/browser/resources/downloads.html (left): http://codereview.chromium.org/8511046/diff/1022/chrome/browser/resources/downloads.html#oldcode31 chrome/browser/resources/downloads.html:31: } So, you couldn't find any occurrences of ...
9 years, 1 month ago (2011-11-10 09:30:46 UTC) #2
Dan Beam
Oh yeah, I forgot, there's a peculiarity about the margin-bottom on the elements right above ...
9 years, 1 month ago (2011-11-10 09:44:04 UTC) #3
Evan Stade
the code as is works as desired. We don't need the 'clearfix'. http://codereview.chromium.org/8511046/diff/1022/chrome/browser/resources/downloads.html File chrome/browser/resources/downloads.html ...
9 years, 1 month ago (2011-11-10 17:51:47 UTC) #4
Dan Beam
On 2011/11/10 09:44:04, Dan Beam wrote: > Oh yeah, I forgot, there's a peculiarity about ...
9 years, 1 month ago (2011-11-10 18:58:25 UTC) #5
Rick Byers
I agree this wasn't really adding value as-is. But are we sure there's no value ...
9 years, 1 month ago (2011-11-10 21:59:08 UTC) #6
Evan Stade
On 2011/11/10 21:59:08, Rick Byers wrote: > I agree this wasn't really adding value as-is. ...
9 years, 1 month ago (2011-11-10 23:36:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/8511046/1022
9 years, 1 month ago (2011-11-11 22:43:06 UTC) #8
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 22:43:10 UTC) #9 
Can't process patch for file chrome/browser/resources/gpu_internals.js.
File's status is None, patchset upload is incomplete.

Powered by Google App Engine
This is Rietveld 408576698